When WKWebView's content inset is used, we sometimes fail to reveal the caret as the user types. <rdar://problem/52103924>
Created attachment 373825 [details] Fixes the bug
Comment on attachment 373825 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=373825&action=review > Source/WebCore/rendering/RenderLayer.cpp:2685 > LayoutRect viewRect = frameView.visualViewportRectExpandedByContentInsets(); > > + maxScrollPosition = frameView.scrollPositionFromOffset(ScrollPosition(frameView.totalContentsSize() - flooredIntSize(viewRect.size()))); We need to clean this up so that webcore code doesn't have to get muddied with inset complexity.
Filed https://bugs.webkit.org/show_bug.cgi?id=199682 and https://bugs.webkit.org/show_bug.cgi?id=199683 Will add links as comments.
Created attachment 373861 [details] Patch for landing
Comment on attachment 373861 [details] Patch for landing Clearing flags on attachment: 373861 Committed r247327: <https://trac.webkit.org/changeset/247327>
All reviewed patches have been landed. Closing bug.
Fixed the test in https://trac.webkit.org/changeset/247373.