Bug 19966 - CSS variables crash when using hex notation for colors
: CSS variables crash when using hex notation for colors
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: CSS
: 528+ (Nightly build)
: Macintosh Intel Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
http://rossboucher.com/test/index.html
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-09 14:13 PDT by boucher
Modified: 2008-07-22 01:28 PDT (History)
1 user (show)

See Also:


Attachments
First attempt (17.09 KB, patch)
2008-07-12 06:44 PDT, Rob Buis
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description boucher 2008-07-09 14:13:29 PDT
The new CSS variable mechanism will crash if you specify a color variable using hex (#) notation.  

The URL attached has a simple test case.  

The offending line:

@-webkit-variables { defaultTextColor: #333; }
Comment 1 Rob Buis 2008-07-12 06:44:44 PDT
Created attachment 22255 [details]
First attempt

From the testcase and spec example I guess hex colors should be supported, this fixes that. I wonder whether there are more CSSPrimitiveValues that are not supported for the css variables...
Cheers,

Rob.
Comment 2 mitz@webkit.org 2008-07-20 14:32:42 PDT
Comment on attachment 22255 [details]
First attempt

The code changes look good, but please consider changing the test to dump as text, using getComputedStyle. Thanks!
Comment 3 Rob Buis 2008-07-22 01:28:57 PDT
Landed in r35272.