Bug 199651 - [WHLSL] Import more JS reference spec tests
Summary: [WHLSL] Import more JS reference spec tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 199595
  Show dependency tree / graph
 
Reported: 2019-07-09 19:08 PDT by Saam Barati
Modified: 2019-07-11 07:37 PDT (History)
9 users (show)

See Also:

Attachments
patch (39.36 KB, patch)
2019-07-09 19:12 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (43.60 KB, patch)
2019-07-09 19:32 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (43.61 KB, patch)
2019-07-10 11:50 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-07-09 19:08:07 PDT 
...
Comment 1 Saam Barati 2019-07-09 19:12:23 PDT 
Created attachment 373808 [details]
patch
Comment 2 Saam Barati 2019-07-09 19:32:35 PDT 
Created attachment 373811 [details]
patch
Comment 3 Saam Barati 2019-07-10 11:49:29 PDT 
Rubber stamped by Robin
Comment 4 Saam Barati 2019-07-10 11:50:32 PDT 
Created attachment 373852 [details]
patch for landing
Comment 5 WebKit Commit Bot 2019-07-10 13:02:01 PDT 
Comment on attachment 373852 [details]
patch for landing

Clearing flags on attachment: 373852

Committed r247319: <https://trac.webkit.org/changeset/247319>
Comment 6 WebKit Commit Bot 2019-07-10 13:02:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-07-10 13:03:21 PDT 
<rdar://problem/52908330>
Comment 8 Truitt Savell 2019-07-10 15:52:21 PDT 
It looks like the new test added in https://trac.webkit.org/changeset/247319/webkit

webgpu/whlsl-builtin-vectors-2.html

is timing out.

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgpu%2Fwhlsl-builtin-vectors-2.html
Comment 9 Truitt Savell 2019-07-10 17:07:04 PDT 
Same asked offline for me to mark the test slow. Marked as slow for Mojave Debug WK2 in:
https://trac.webkit.org/changeset/247333/webkit
Comment 10 Truitt Savell 2019-07-11 07:37:53 PDT 
Marking slow has allowed the test to start passing.