Bug 199647 - [WHLSL] Import another round of JS spec tests
Summary: [WHLSL] Import another round of JS spec tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 199595
  Show dependency tree / graph
 
Reported: 2019-07-09 16:32 PDT by Saam Barati
Modified: 2019-07-09 17:43 PDT (History)
8 users (show)

See Also:

Attachments
patch (26.34 KB, patch)
2019-07-09 16:36 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (25.06 KB, patch)
2019-07-09 17:14 PDT, Saam Barati 		mmaxfield: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-07-09 16:32:32 PDT 
...
Comment 1 Saam Barati 2019-07-09 16:36:54 PDT 
Created attachment 373789 [details]
patch
Comment 2 Robin Morisset 2019-07-09 17:04:37 PDT 
Comment on attachment 373789 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373789&action=review

> LayoutTests/webgpu/whlsl-float-math.html:19
> +        bool foo2()

I don't understand, how is foo2() different from foo() ? And from foo3, 4 and 5?

> LayoutTests/webgpu/whlsl-float-math.html:41
> +            return bar(7.5);

Same between foo6 and foo7

> LayoutTests/webgpu/whlsl-float-math.html:49
> +            return float(7.5);

Same between foo9 and foo10

> LayoutTests/webgpu/whlsl-float-math.html:102
> +    await checkFail(

Again, this test is a duplicate of the previous one.
Comment 3 Saam Barati 2019-07-09 17:14:24 PDT 
Created attachment 373797 [details]
patch
Comment 4 Myles C. Maxfield 2019-07-09 17:16:50 PDT 
Comment on attachment 373797 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373797&action=review

> LayoutTests/webgpu/whlsl-bad-ander.html:1
> +<!DOCTYPE html><!-- webkit-test-runner [ experimental:WebGPUEnabled=true ] -->

Shouldn't need this webkit-test-runner comment on any test.
Comment 5 Saam Barati 2019-07-09 17:21:26 PDT 
(In reply to Myles C. Maxfield from comment #4)
> Comment on attachment 373797 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373797&action=review
> 
> > LayoutTests/webgpu/whlsl-bad-ander.html:1
> > +<!DOCTYPE html><!-- webkit-test-runner [ experimental:WebGPUEnabled=true ] -->
> 
> Shouldn't need this webkit-test-runner comment on any test.

Will remove from all tests inside webgpu/
Comment 6 Saam Barati 2019-07-09 17:23:40 PDT 
landed in:
https://trac.webkit.org/changeset/247289/webkit
Comment 7 Radar WebKit Bug Importer 2019-07-09 17:43:50 PDT 
<rdar://problem/52862550>