Bug 199645 – TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON is a flaky crash

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON is a flaky crash, failing 2-3 assertions at a time:

 TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        ASSERTION FAILED: !m_startTime && !m_referenceMonotonicTime && !m_referenceWallTime
        ./loader/LoadTiming.cpp(56) : void WebCore::LoadTiming::markStartTime()
        1   0x2026819a9 WTFCrash
        2   0x1f000694b WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x1f2c3c6f0 WebCore::LoadTiming::markStartTime()
        4   0x1f2bbda79 WebCore::LoadTiming::markStartTimeAndFetchStart()
        5   0x1f2bbd222 WebCore::DocumentLoader::startLoadingMainResource()
        6   0x1f2c2faa5 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WebCore::NavigationPolicyDecision, WebCore::AllowNavigationToInvalidURL)::$_11::operator()()
        7   0x1f2c2f699 WTF::Detail::CallableWrapper<WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WebCore::NavigationPolicyDecision, WebCore::AllowNavigationToInvalidURL)::$_11, void>::call()
        8   0x1f00139dd WTF::Function<void ()>::operator()() const
        9   0x1f1695d54 WTF::CompletionHandler<void ()>::operator()()
        10  0x1f2c0f957 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WebCore::NavigationPolicyDecision, WebCore::AllowNavigationToInvalidURL)
        11  0x1f2c0ea7b WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::RefPtr<WebCore::FormState, WTF::DumbPtrTraits<WebCore::FormState> >&&, WebCore::AllowNavigationToInvalidURL, WebCore::ShouldTreatAsContinuingLoad, WTF::CompletionHandler<void ()>&&)
        12  0x1f2c07f07 WebCore::FrameLoader::loadDifferentDocumentItem(WebCore::HistoryItem&, WebCore::HistoryItem*, WebCore::FrameLoadType, WebCore::FrameLoader::FormSubmissionCacheLoadPolicy, WebCore::ShouldTreatAsContinuingLoad)
        13  0x1f2c1a9fd WebCore::FrameLoader::loadItem(WebCore::HistoryItem&, WebCore::HistoryItem*, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
        14  0x1f2c1dc5f WebCore::HistoryController::recursiveGoToItem(WebCore::HistoryItem&, WebCore::HistoryItem*, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
        15  0x1f2c1d9c6 WebCore::HistoryController::goToItem(WebCore::HistoryItem&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
        16  0x1f2e4a3bb WebCore::Page::goToItem(WebCore::HistoryItem&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
        17  0x1044f7aa6 WebKit::WebPage::goToBackForwardItem(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&)
        18  0x1045926a8 void IPC::callMemberFunctionImpl<WebKit::WebPage, void (WebKit::WebPage::*)(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&), std::__1::tuple<unsigned long long, WebCore::BackForwardItemIdentifier, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData> >, 0ul, 1ul, 2ul, 3ul, 4ul>(WebKit::WebPage*, void (WebKit::WebPage::*)(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&), std::__1::tuple<unsigned long long, WebCore::BackForwardItemIdentifier, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData> >&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul>)
        19  0x10458f4f0 void IPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&), std::__1::tuple<unsigned long long, WebCore::BackForwardItemIdentifier, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData> >, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul> >(std::__1::tuple<unsigned long long, WebCore::BackForwardItemIdentifier, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData> >&&, WebKit::WebPage*, void (WebKit::WebPage::*)(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&))
        20  0x10456c77e void IPC::handleMessage<Messages::WebPage::GoToBackForwardItem, WebKit::WebPage, void (WebKit::WebPage::*)(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&)>(IPC::Decoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&))
        21  0x104563978 WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::Decoder&)
        22  0x10450518e WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
        23  0x103145e5a IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&)
        24  0x1040a6c3d WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
        25  0x1030ce77c IPC::Connection::dispatchMessage(IPC::Decoder&)
        26  0x1030c0f91 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)
        27  0x1030cf6c7 IPC::Connection::dispatchOneIncomingMessage()
        28  0x1030efca8 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()()
        29  0x1030efbb9 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14, void>::call()
        30  0x2026abefd WTF::Function<void ()>::operator()() const
        31  0x20270e06d WTF::RunLoop::performWork()
        Received data during response processing, queuing it.
        ASSERTION FAILED: !loader || !m_provisionalDocumentLoader
        ./loader/FrameLoader.cpp(1956) : void WebCore::FrameLoader::setProvisionalDocumentLoader(WebCore::DocumentLoader *)
        1   0x23a6819a9 WTFCrash
        2   0x22800694b WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x22ac01a71 WebCore::FrameLoader::setProvisionalDocumentLoader(WebCore::DocumentLoader*)
        4   0x22ac0f66c WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WebCore::NavigationPolicyDecision, WebCore::AllowNavigationToInvalidURL)
        5   0x22ac0ea7b WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::RefPtr<WebCore::FormState, WTF::DumbPtrTraits<WebCore::FormState> >&&, WebCore::AllowNavigationToInvalidURL, WebCore::ShouldTreatAsContinuingLoad, WTF::CompletionHandler<void ()>&&)
        6   0x22ac07f07 WebCore::FrameLoader::loadDifferentDocumentItem(WebCore::HistoryItem&, WebCore::HistoryItem*, WebCore::FrameLoadType, WebCore::FrameLoader::FormSubmissionCacheLoadPolicy, WebCore::ShouldTreatAsContinuingLoad)
        7   0x22ac1a9fd WebCore::FrameLoader::loadItem(WebCore::HistoryItem&, WebCore::HistoryItem*, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
        8   0x22ac1dc5f WebCore::HistoryController::recursiveGoToItem(WebCore::HistoryItem&, WebCore::HistoryItem*, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
        9   0x22ac1d9c6 WebCore::HistoryController::goToItem(WebCore::HistoryItem&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
        10  0x22ae4a3bb WebCore::Page::goToItem(WebCore::HistoryItem&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad)
        11  0x10dafaaa6 WebKit::WebPage::goToBackForwardItem(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&)
        12  0x10db956a8 void IPC::callMemberFunctionImpl<WebKit::WebPage, void (WebKit::WebPage::*)(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&), std::__1::tuple<unsigned long long, WebCore::BackForwardItemIdentifier, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData> >, 0ul, 1ul, 2ul, 3ul, 4ul>(WebKit::WebPage*, void (WebKit::WebPage::*)(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&), std::__1::tuple<unsigned long long, WebCore::BackForwardItemIdentifier, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData> >&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul>)
        13  0x10db924f0 void IPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&), std::__1::tuple<unsigned long long, WebCore::BackForwardItemIdentifier, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData> >, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul> >(std::__1::tuple<unsigned long long, WebCore::BackForwardItemIdentifier, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData> >&&, WebKit::WebPage*, void (WebKit::WebPage::*)(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&))
        14  0x10db6f77e void IPC::handleMessage<Messages::WebPage::GoToBackForwardItem, WebKit::WebPage, void (WebKit::WebPage::*)(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&)>(IPC::Decoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(unsigned long long, WebCore::BackForwardItemIdentifier const&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, WTF::Optional<WebKit::WebsitePoliciesData>&&))
        15  0x10db66978 WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::Decoder&)
        16  0x10db0818e WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
        17  0x10c748e5a IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&)
        18  0x10d6a9c3d WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
        19  0x10c6d177c IPC::Connection::dispatchMessage(IPC::Decoder&)
        20  0x10c6c3f91 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)
        21  0x10c6d26c7 IPC::Connection::dispatchOneIncomingMessage()
        22  0x10c6f2ca8 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()()
        23  0x10c6f2bb9 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14, void>::call()
        24  0x23a6abefd WTF::Function<void ()>::operator()() const
        25  0x23a70e06d WTF::RunLoop::performWork()
        26  0x23a70e934 WTF::RunLoop::performWork(void*)
        27  0x7fff4561b581 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
        28  0x7fff456d38ac __CFRunLoopDoSource0
        29  0x7fff455fe530 __CFRunLoopDoSources0
        30  0x7fff455fd9ad __CFRunLoopRun
        31  0x7fff455fd207 CFRunLoopRunSpecific
        Received data during response processing, queuing it.
        SHOULD NEVER BE REACHED
        /Volumes/Data/slave/highsierra-debug/build/Source/WebKit/UIProcess/WebPageProxy.cpp(762) : bool WebKit::WebPageProxy::suspendCurrentPageIfPossible(API::Navigation &, Optional<uint64_t>, WebKit::ProcessSwapRequestedByClient, WebKit::ShouldDelayClosingUntilEnteringAcceleratedCompositingMode)
        1   0x1063c59a9 WTFCrash
        2   0x10b86b3bb WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x10c36dcc7 WebKit::WebPageProxy::suspendCurrentPageIfPossible(API::Navigation&, WTF::Optional<unsigned long long>, WebKit::ProcessSwapRequestedByClient, WebKit::ShouldDelayClosingUntilEnteringAcceleratedCompositingMode)
        4   0x10c3815d1 WebKit::WebPageProxy::commitProvisionalPage(unsigned long long, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&)
        5   0x10c1c8c5b WebKit::ProvisionalPageProxy::didCommitLoadForFrame(unsigned long long, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&)
        6   0x10c1ffe73 void IPC::callMemberFunctionImpl<WebKit::ProvisionalPageProxy, void (WebKit::ProvisionalPageProxy::*)(unsigned long long, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&), std::__1::tuple<unsigned long long, unsigned long long, WTF::String, bool, unsigned int, WebCore::CertificateInfo, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData>, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul, 6ul, 7ul, 8ul>(WebKit::ProvisionalPageProxy*, void (WebKit::ProvisionalPageProxy::*)(unsigned long long, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&), std::__1::tuple<unsigned long long, unsigned long long, WTF::String, bool, unsigned int, WebCore::CertificateInfo, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul, 6ul, 7ul, 8ul>)
        7   0x10c1f8860 void IPC::callMemberFunction<WebKit::ProvisionalPageProxy, void (WebKit::ProvisionalPageProxy::*)(unsigned long long, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&), std::__1::tuple<unsigned long long, unsigned long long, WTF::String, bool, unsigned int, WebCore::CertificateInfo, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData>, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul, 6ul, 7ul, 8ul> >(std::__1::tuple<unsigned long long, unsigned long long, WTF::String, bool, unsigned int, WebCore::CertificateInfo, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData>&&, WebKit::ProvisionalPageProxy*, void (WebKit::ProvisionalPageProxy::*)(unsigned long long, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&))
        8   0x10c1cb90f void IPC::handleMessage<Messages::WebPageProxy::DidCommitLoadForFrame, WebKit::ProvisionalPageProxy, void (WebKit::ProvisionalPageProxy::*)(unsigned long long, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&)>(IPC::Decoder&, WebKit::ProvisionalPageProxy*, void (WebKit::ProvisionalPageProxy::*)(unsigned long long, unsigned long long, WTF::String const&, bool, unsigned int, WebCore::CertificateInfo const&, bool, WTF::Optional<WebCore::HasInsecureContent>, WebKit::UserData const&))
        9   0x10c1ca50c WebKit::ProvisionalPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
        10  0x10b957e5a IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&)
        11  0x10c1996c4 WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&)
        12  0x10c4a3eda WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
        13  0x10b8e077c IPC::Connection::dispatchMessage(IPC::Decoder&)
        14  0x10b8d2f91 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)
        15  0x10b8ddbd1 IPC::Connection::dispatchIncomingMessages()
        16  0x10b901c92 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()()
        17  0x10b901bb9 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14, void>::call()
        18  0x1063efefd WTF::Function<void ()>::operator()() const
        19  0x106451f83 WTF::RunLoop::performWork()
        20  0x106452934 WTF::RunLoop::performWork(void*)
        21  0x7fff4561b581 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
        22  0x7fff456d38ac __CFRunLoopDoSource0
        23  0x7fff455fe530 __CFRunLoopDoSources0
        24  0x7fff455fd9ad __CFRunLoopRun
        25  0x7fff455fd207 CFRunLoopRunSpecific
        26  0x7fff47715e76 -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
        27  0x7fff4779be65 -[NSRunLoop(NSRunLoop) runUntilDate:]
        28  0x1051d2bed TestWebKitAPI::Util::sleep(double)
        29  0x105003e44 runQuickBackForwardNavigationTest(ShouldEnablePSON)
        30  0x105004958 ProcessSwap_QuickBackForwardNavigationWithPSON_Test::TestBody()
        31  0x1053c463e void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)

https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/builds/9890/steps/run-api-tests/logs/stdio
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK1%20%28Tests%29/builds/9851/steps/run-api-tests/logs/stdio
https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/3461/steps/run-api-tests/logs/stdio

[Radar WebKit Bug Importer]

<rdar://problem/52856112>

[Ryan Haddad]

This test was added in February with https://trac.webkit.org/changeset/241606/webkit. 

I don't have a regression point.

[Chris Dumez]

Created attachment 383644 [details]
Patch

[Alex Christensen]

Comment on attachment 383644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383644&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2337
> -    EXPECT_EQ(3u, backForwardListURLs.size());
> +    RELEASE_ASSERT(backForwardListURLs.size() == 3u);

I don't see why this is necessary.

[Chris Dumez]

Comment on attachment 383644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383644&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2337
>> +    RELEASE_ASSERT(backForwardListURLs.size() == 3u);
> 
> I don't see why this is necessary.

If backForwardListURLs.size() is 2 for example (which I saw locally), it ends up crashing in an obscure fashion later on.
I'd rather we crash right away if the list size if wrong.

[WebKit Commit Bot]

Comment on attachment 383644 [details]
Patch

Clearing flags on attachment: 383644

Committed r252600: <https://trac.webkit.org/changeset/252600>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.