Bug 199637 - [iOS WK2] Use Optional<> for two data members of WKWebView
Summary: [iOS WK2] Use Optional<> for two data members of WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-09 13:25 PDT by Simon Fraser (smfr)
Modified: 2019-07-09 18:36 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.98 KB, patch)
2019-07-09 13:26 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-07-09 13:25:59 PDT 
[iOS WK2] Use Optional<> for two data members of WKWebView
Comment 1 Simon Fraser (smfr) 2019-07-09 13:26:46 PDT 
Created attachment 373751 [details]
Patch
Comment 2 Tim Horton 2019-07-09 13:29:59 PDT 
Comment on attachment 373751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373751&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:6310
> +    _viewLayoutSizeOverride = WTF::nullopt;
> +    _maximumUnobscuredSizeOverride = WTF::nullopt;

.clear()? 🤷‍♂️
Comment 3 WebKit Commit Bot 2019-07-09 18:31:09 PDT 
Comment on attachment 373751 [details]
Patch

Clearing flags on attachment: 373751

Committed r247290: <https://trac.webkit.org/changeset/247290>
Comment 4 WebKit Commit Bot 2019-07-09 18:31:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-07-09 18:36:01 PDT 
<rdar://problem/52866038>