RESOLVED FIXED 199637
[iOS WK2] Use Optional<> for two data members of WKWebView 
https://bugs.webkit.org/show_bug.cgi?id=199637
Summary [iOS WK2] Use Optional<> for two data members of WKWebView
Simon Fraser (smfr)
Reported 2019-07-09 13:25:59 PDT
[iOS WK2] Use Optional<> for two data members of WKWebView
Attachments
Patch (6.98 KB, patch)
2019-07-09 13:26 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-07-09 13:26:46 PDT
Created attachment 373751 [details] Patch
Tim Horton
Comment 2 2019-07-09 13:29:59 PDT
Comment on attachment 373751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373751&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:6310 > + _viewLayoutSizeOverride = WTF::nullopt; > + _maximumUnobscuredSizeOverride = WTF::nullopt; .clear()? 🤷‍♂️
WebKit Commit Bot
Comment 3 2019-07-09 18:31:09 PDT
Comment on attachment 373751 [details] Patch Clearing flags on attachment: 373751 Committed r247290: <https://trac.webkit.org/changeset/247290>
WebKit Commit Bot
Comment 4 2019-07-09 18:31:11 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-07-09 18:36:01 PDT
<rdar://problem/52866038>
Note You need to log in before you can comment on or make changes to this bug.