Bug 199635 – Stopping a cloned MediaStream video track should not stop any other video track

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Stopping a cloned MediaStream video track should not stop any other video track

[youenn fablet]

Created attachment 373763 [details]
Patch

[EWS Watchlist]

Attachment 373763 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:236:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Comment on attachment 373763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373763&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSource.h:112
> +    virtual void requestToEnd(Observer& callingObserver);

Is this change necessary?

[youenn fablet]

Comment on attachment 373763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373763&action=review

>> Source/WebCore/platform/mediastream/RealtimeMediaSource.h:112
>> +    virtual void requestToEnd(Observer& callingObserver);
> 
> Is this change necessary?

Unfortunately yes.
We might want to improve the model at some point to remove this.

[WebKit Commit Bot]

Comment on attachment 373763 [details]
Patch

Clearing flags on attachment: 373763

Committed r247391: <https://trac.webkit.org/changeset/247391>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53015111>