Bug 199622 - Revert conditional WebPageProxy check to grant universal file read sandbox upon correct sandbox creation
Summary: Revert conditional WebPageProxy check to grant universal file read sandbox up...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-09 09:31 PDT by youenn fablet
Modified: 2019-07-09 12:56 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.09 KB, patch)
2019-07-09 09:38 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-07-09 09:31:06 PDT
https://trac.webkit.org/changeset/246694 made it so that WebPageProxy would set m_mayHaveUniversalFileReadSandboxExtension to true only if the sandbox extension to '/' is successfully created.
As shown in rdar://problem/52357508, this causes some breakage.
Comment 1 youenn fablet 2019-07-09 09:31:14 PDT
<rdar://problem/52357508>
Comment 2 youenn fablet 2019-07-09 09:38:49 PDT
Created attachment 373724 [details]
Patch
Comment 3 WebKit Commit Bot 2019-07-09 12:56:30 PDT
Comment on attachment 373724 [details]
Patch

Clearing flags on attachment: 373724

Committed r247272: <https://trac.webkit.org/changeset/247272>
Comment 4 WebKit Commit Bot 2019-07-09 12:56:32 PDT
All reviewed patches have been landed.  Closing bug.