Bug 199618 - [Pointer Events] Scroll indicators should not show for scrollable content with touch-action: none
Summary: [Pointer Events] Scroll indicators should not show for scrollable content wit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-09 07:19 PDT by Antoine Quint
Modified: 2019-07-09 11:45 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.81 KB, patch)
2019-07-09 07:25 PDT, Antoine Quint
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-07-09 07:19:17 PDT
[Pointer Events] Scroll indicators should not show for scrollable content with touch-action: none
Comment 1 Antoine Quint 2019-07-09 07:25:18 PDT
Created attachment 373714 [details]
Patch
Comment 2 Antoine Quint 2019-07-09 07:28:21 PDT
@smfr: is there a better way to determine a given UIGestureRecognizer is the pan gesture recognizer of a UIScrollView created by WebKit but isn't the WKWebView's UIScrollView's? Looking at its delegate's class works fine, but maybe there's a clearer way?
Comment 3 Simon Fraser (smfr) 2019-07-09 10:44:58 PDT
Comment on attachment 373714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373714&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1402
> +        if ([view isKindOfClass:[UIScrollView class]]) {
> +            if (auto* delegate = ((UIScrollView*)view).delegate)
> +                return [delegate isKindOfClass:[WKScrollingNodeScrollViewDelegate class]];
> +        }

You could just check that the UIScrollView is a WKChildScrollView?
Comment 4 Antoine Quint 2019-07-09 11:44:06 PDT
Committed r247265: <https://trac.webkit.org/changeset/247265>
Comment 5 Radar WebKit Bug Importer 2019-07-09 11:45:37 PDT
<rdar://problem/52844700>