[GStreamer] Skip http/tests/media/hls/hls-video-resize.html
Created attachment 373711 [details] Patch
CC Jeremy, perhaps as the original test author they have points to add, but it seems like an Apple specific test from my investigation.
Comment on attachment 373711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373711&action=review > LayoutTests/ChangeLog:13 > + However, there is a provision mentioned implicity that the UA can implicitly?
Created attachment 373712 [details] Patch Fix spelling error and give it 24hr to see if Jeremy has anything further to add
Comment on attachment 373712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373712&action=review > LayoutTests/ChangeLog:17 > + Generally speaking, the HTML spec says that HAVE_METADATA => video > + dimensions are available. Only when the state is < HAVE_METADATA > + is it specified that "If the element's readyState attribute is > + HAVE_NOTHING, then the [width, height] attributes must return 0." > + > + However, there is a provision mentioned implicitly that the UA can > + be in HAVE_METADATA and have received no video data. "When no > + video data is available (the element's readyState attribute is > + either HAVE_NOTHING, or HAVE_METADATA but no video data has yet > + been obtained at all..." It seems like it would be worth having the spec updated to get rid of the ambiguity, can you please file a spec bug?
(In reply to Charlie Turner from comment #4) > Created attachment 373712 [details] > Patch > > Fix spelling error and give it 24hr to see if Jeremy has anything further to > add Jeremy is not longer actively contributing to WebKit
(In reply to Eric Carlson from comment #5) > Comment on attachment 373712 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373712&action=review > > > LayoutTests/ChangeLog:17 > > + Generally speaking, the HTML spec says that HAVE_METADATA => video > > + dimensions are available. Only when the state is < HAVE_METADATA > > + is it specified that "If the element's readyState attribute is > > + HAVE_NOTHING, then the [width, height] attributes must return 0." > > + > > + However, there is a provision mentioned implicitly that the UA can > > + be in HAVE_METADATA and have received no video data. "When no > > + video data is available (the element's readyState attribute is > > + either HAVE_NOTHING, or HAVE_METADATA but no video data has yet > > + been obtained at all..." > > It seems like it would be worth having the spec updated to get rid of the > ambiguity, can you please file a spec bug? Sure, I filed https://github.com/whatwg/html/issues/4761 I will update here when I find out more about this.
So this can land then?
Created attachment 381598 [details] Patch for landing
No movement on the spec bug, skipping in the absense of input from them.
Comment on attachment 381598 [details] Patch for landing Clearing flags on attachment: 381598 Committed r251462: <https://trac.webkit.org/changeset/251462>
All reviewed patches have been landed. Closing bug.