Bug 199616 - Remove rel=subresource tests
Summary: Remove rel=subresource tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-09 04:11 PDT by Rob Buis
Modified: 2019-07-09 12:43 PDT (History)
7 users (show)

See Also:


Attachments
Patch (16.96 KB, patch)
2019-07-09 04:22 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (15.43 KB, patch)
2019-07-09 04:23 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.70 MB, application/zip)
2019-07-09 05:42 PDT, Build Bot
no flags Details
Patch (11.46 KB, patch)
2019-07-09 06:06 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.19 MB, application/zip)
2019-07-09 07:14 PDT, Build Bot
no flags Details
Patch (8.21 KB, patch)
2019-07-09 07:53 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (8.21 KB, patch)
2019-07-09 11:00 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2019-07-09 04:11:39 PDT
Subresource was attempted to be removed here (https://bugs.webkit.org/show_bug.cgi?id=183540) but not everything was removed.
Comment 1 Rob Buis 2019-07-09 04:22:04 PDT
Created attachment 373706 [details]
Patch
Comment 2 Rob Buis 2019-07-09 04:23:46 PDT
Created attachment 373707 [details]
Patch
Comment 3 Build Bot 2019-07-09 05:42:39 PDT
Comment on attachment 373707 [details]
Patch

Attachment 373707 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12697130

New failing tests:
webarchive/test-link-rel-prefetch-beforeload.html
Comment 4 Build Bot 2019-07-09 05:42:40 PDT
Created attachment 373709 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 5 Rob Buis 2019-07-09 06:06:44 PDT
Created attachment 373710 [details]
Patch
Comment 6 Build Bot 2019-07-09 07:14:26 PDT
Comment on attachment 373710 [details]
Patch

Attachment 373710 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12697547

New failing tests:
webarchive/test-link-rel-prefetch-beforeload.html
Comment 7 Build Bot 2019-07-09 07:14:28 PDT
Created attachment 373713 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 8 Rob Buis 2019-07-09 07:53:53 PDT
Created attachment 373719 [details]
Patch
Comment 9 Ryosuke Niwa 2019-07-09 10:51:19 PDT
Comment on attachment 373719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373719&action=review

> LayoutTests/ChangeLog:3
> +        Remove rel=subresource

Please update the title here to reflect the fact we're removing tests, not the implementation that had already been removed.
Comment 10 Rob Buis 2019-07-09 11:00:42 PDT
Created attachment 373734 [details]
Patch
Comment 11 WebKit Commit Bot 2019-07-09 12:39:00 PDT
Comment on attachment 373734 [details]
Patch

Clearing flags on attachment: 373734

Committed r247271: <https://trac.webkit.org/changeset/247271>
Comment 12 WebKit Commit Bot 2019-07-09 12:39:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2019-07-09 12:43:03 PDT
<rdar://problem/52847467>