Bug 199611 - Web Inspector: Canvas: replace WTF::Vector with std::initializer_list in CallTracer to avoid dynamic allocations
Summary: Web Inspector: Canvas: replace WTF::Vector with std::initializer_list in Call...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-09 01:43 PDT by Devin Rousso
Modified: 2019-07-09 14:08 PDT (History)
8 users (show)

See Also:

Attachments
Patch (35.79 KB, patch)
2019-07-09 01:58 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (44.76 KB, patch)
2019-07-09 08:42 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-07-09 01:43:06 PDT 
.
Comment 1 Devin Rousso 2019-07-09 01:58:20 PDT 
Created attachment 373702 [details]
Patch

Test on bots :)
Comment 2 Devin Rousso 2019-07-09 08:42:33 PDT 
Created attachment 373720 [details]
Patch

Oops.  Forgot to update bindings test :P
Comment 3 Joseph Pecoraro 2019-07-09 13:26:15 PDT 
Comment on attachment 373720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373720&action=review

rs=me

> Source/WebCore/ChangeLog:41
> +                  would otherwise be treated as an array of numbers.

Weird whitespace in these ChangeLogs.
Comment 4 Devin Rousso 2019-07-09 13:37:00 PDT 
Comment on attachment 373720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373720&action=review

>> Source/WebCore/ChangeLog:41
>> +                  would otherwise be treated as an array of numbers.
> 
> Weird whitespace in these ChangeLogs.

I prefer this, as the "prefix" (e.g. "Drive-by") is much easier to see/identify/read.
Comment 5 WebKit Commit Bot 2019-07-09 14:07:59 PDT 
Comment on attachment 373720 [details]
Patch

Clearing flags on attachment: 373720

Committed r247278: <https://trac.webkit.org/changeset/247278>
Comment 6 WebKit Commit Bot 2019-07-09 14:08:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-07-09 14:08:45 PDT 
<rdar://problem/52852082>