Bug 199596 - Null check HistoryItems given to loadDifferentDocumentItem
Summary: Null check HistoryItems given to loadDifferentDocumentItem
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-08 15:53 PDT by Alex Christensen
Modified: 2019-07-09 11:56 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2019-07-08 15:54 PDT, Alex Christensen 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-07-08 15:53:33 PDT 
Null check HistoryItems given to loadDifferentDocumentItem
Comment 1 Alex Christensen 2019-07-08 15:54:50 PDT 
Created attachment 373675 [details]
Patch
Comment 2 Alex Christensen 2019-07-08 15:54:52 PDT 
<rdar://problem/49884391>
Comment 3 Ryosuke Niwa 2019-07-08 19:55:46 PDT 
Comment on attachment 373675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373675&action=review

> Source/WebCore/loader/FrameLoader.cpp:3874
> +    if (item)

Should we add a debug assertion / release logging when item is null?
Comment 4 Alex Christensen 2019-07-09 11:56:01 PDT 
http://trac.webkit.org/r247266