Bug 199591 - Use WeakHashSet for WebUserContentControllerProxy::m_processes
Summary: Use WeakHashSet for WebUserContentControllerProxy::m_processes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-08 15:15 PDT by Chris Dumez
Modified: 2019-07-08 17:53 PDT (History)
9 users (show)

See Also:

Attachments
Patch (19.35 KB, patch)
2019-07-08 15:27 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (20.90 KB, patch)
2019-07-08 17:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (19.40 KB, patch)
2019-07-08 17:09 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-07-08 15:15:39 PDT 
Use WeakHashSet for WebUserContentControllerProxy::m_processses for safety. In theory, a WebProcessProxy could stay in the map if we failed to call WebProcessProxy::shutDown() before destroying it.
Comment 1 Chris Dumez 2019-07-08 15:15:54 PDT 
<rdar://problem/52798721>
Comment 2 Chris Dumez 2019-07-08 15:27:10 PDT 
Created attachment 373672 [details]
Patch
Comment 3 youenn fablet 2019-07-08 16:05:56 PDT 
Comment on attachment 373672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373672&action=review

> Source/WebKit/ChangeLog:10
> +        stay in the map if we failed to call WebProcessProxy::shutDown() before destroying it.

Since we are trying to add/remove the entries in the map properly, should we add some debug asserts that we are actually doing this correctly?
Comment 4 Chris Dumez 2019-07-08 17:07:11 PDT 
Created attachment 373680 [details]
Patch
Comment 5 Chris Dumez 2019-07-08 17:09:58 PDT 
Created attachment 373681 [details]
Patch
Comment 6 WebKit Commit Bot 2019-07-08 17:53:33 PDT 
Comment on attachment 373681 [details]
Patch

Clearing flags on attachment: 373681

Committed r247243: <https://trac.webkit.org/changeset/247243>
Comment 7 WebKit Commit Bot 2019-07-08 17:53:35 PDT 
All reviewed patches have been landed.  Closing bug.