WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
199591
Use WeakHashSet for WebUserContentControllerProxy::m_processes
https://bugs.webkit.org/show_bug.cgi?id=199591
Summary
Use WeakHashSet for WebUserContentControllerProxy::m_processes
Chris Dumez
Reported
2019-07-08 15:15:39 PDT
Use WeakHashSet for WebUserContentControllerProxy::m_processses for safety. In theory, a WebProcessProxy could stay in the map if we failed to call WebProcessProxy::shutDown() before destroying it.
Attachments
Patch
(19.35 KB, patch)
2019-07-08 15:27 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(20.90 KB, patch)
2019-07-08 17:07 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(19.40 KB, patch)
2019-07-08 17:09 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2019-07-08 15:15:54 PDT
<
rdar://problem/52798721
>
Chris Dumez
Comment 2
2019-07-08 15:27:10 PDT
Created
attachment 373672
[details]
Patch
youenn fablet
Comment 3
2019-07-08 16:05:56 PDT
Comment on
attachment 373672
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=373672&action=review
> Source/WebKit/ChangeLog:10 > + stay in the map if we failed to call WebProcessProxy::shutDown() before destroying it.
Since we are trying to add/remove the entries in the map properly, should we add some debug asserts that we are actually doing this correctly?
Chris Dumez
Comment 4
2019-07-08 17:07:11 PDT
Created
attachment 373680
[details]
Patch
Chris Dumez
Comment 5
2019-07-08 17:09:58 PDT
Created
attachment 373681
[details]
Patch
WebKit Commit Bot
Comment 6
2019-07-08 17:53:33 PDT
Comment on
attachment 373681
[details]
Patch Clearing flags on attachment: 373681 Committed
r247243
: <
https://trac.webkit.org/changeset/247243
>
WebKit Commit Bot
Comment 7
2019-07-08 17:53:35 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug