Cleanup uses of NetworkProces::m_sessionByConnection.
Created attachment 373661 [details] Patch
Created attachment 373663 [details] Patch
Created attachment 373666 [details] Patch
Comment on attachment 373666 [details] Patch Clearing flags on attachment: 373666 Committed r247230: <https://trac.webkit.org/changeset/247230>
All reviewed patches have been landed. Closing bug.
It looks like the changes in https://trac.webkit.org/changeset/247230/webkit caused this test to crash on Debug WK2 for Mac and iOS: storage/domstorage/localstorage/private-browsing-affects-storage.html History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Fdomstorage%2Flocalstorage%2Fprivate-browsing-affects-storage.html Crash: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r247258%20(3475)/storage/domstorage/localstorage/private-browsing-affects-storage-crash-log.txt I was able to reproduce this locally with command: run-webkit-tests --root debug-247230 storage/domstorage/localstorage/private-browsing-affects-storage.html --iterations 20 -f --debug
<rdar://problem/52842659>
(In reply to Truitt Savell from comment #6) > It looks like the changes in https://trac.webkit.org/changeset/247230/webkit > caused this test to crash on Debug WK2 for Mac and iOS: > storage/domstorage/localstorage/private-browsing-affects-storage.html ASSERTION FAILED: addResult.iterator->value == sessionID /Volumes/Data/slave/mojave-debug/build/Source/WebKit/NetworkProcess/NetworkProcess.cpp(2670) : void WebKit::NetworkProcess::webPageWasAdded(IPC::Connection &, PAL::SessionID, WebCore::PageIdentifier, WebCore::PageIdentifier) Chris, can you take a look at this or should we revert?
Reverted r247230 for reason: Caused storage/domstorage/localstorage/private-browsing-affects-storage.html to crash with an assertion. Committed r247277: <https://trac.webkit.org/changeset/247277>
(In reply to Ryan Haddad from comment #8) > (In reply to Truitt Savell from comment #6) > > It looks like the changes in https://trac.webkit.org/changeset/247230/webkit > > caused this test to crash on Debug WK2 for Mac and iOS: > > storage/domstorage/localstorage/private-browsing-affects-storage.html > > ASSERTION FAILED: addResult.iterator->value == sessionID > /Volumes/Data/slave/mojave-debug/build/Source/WebKit/NetworkProcess/ > NetworkProcess.cpp(2670) : void > WebKit::NetworkProcess::webPageWasAdded(IPC::Connection &, PAL::SessionID, > WebCore::PageIdentifier, WebCore::PageIdentifier) > > Chris, can you take a look at this or should we revert? Sihui, Alex, I believe my new assertion may have uncovered a bug in the existing code.
Created attachment 373770 [details] Patch
Comment on attachment 373770 [details] Patch Clearing flags on attachment: 373770 Committed r247283: <https://trac.webkit.org/changeset/247283>