Bug 199580 - Prevent null dereferencing in SubresourceLoader::init's lambda
Summary: Prevent null dereferencing in SubresourceLoader::init's lambda
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-08 11:18 PDT by Alex Christensen
Modified: 2019-07-08 16:34 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2019-07-08 11:19 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.88 KB, patch)
2019-07-08 14:43 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-07-08 11:18:32 PDT 
Prevent null dereferencing in SubresourceLoader::init's lambda
Comment 1 Alex Christensen 2019-07-08 11:19:21 PDT 
Created attachment 373646 [details]
Patch
Comment 2 Ryosuke Niwa 2019-07-08 14:32:42 PDT 
Comment on attachment 373646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373646&action=review

> Source/WebCore/loader/SubresourceLoader.cpp:168
> +            ASSERT_NOT_REACHED();

Should we add a release log for this so that if someone complains that the page load doesn't finish, etc... we can check the sysdiagnose and see that this had happened?
Comment 3 Chris Dumez 2019-07-08 14:41:09 PDT 
Comment on attachment 373646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373646&action=review

>> Source/WebCore/loader/SubresourceLoader.cpp:168
>> +            ASSERT_NOT_REACHED();
> 
> Should we add a release log for this so that if someone complains that the page load doesn't finish, etc... we can check the sysdiagnose and see that this had happened?

RELEASE_LOG_ERROR().
Comment 4 Alex Christensen 2019-07-08 14:43:17 PDT 
Created attachment 373667 [details]
Patch
Comment 5 Alex Christensen 2019-07-08 15:59:23 PDT 
http://trac.webkit.org/r247231
Comment 6 Radar WebKit Bug Importer 2019-07-08 16:03:23 PDT 
<rdar://problem/52802510>