Bug 199578 – test-webkitpy: Explicitly use Python 2.7 lldb library

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

In newer versions of Xcode, the default lldb Python library is the Python 3 library, explicitly use the Python 2.7 library.

[Jonathan Bedard]

<rdar://problem/51853557>

[Jonathan Bedard]

Created attachment 373643 [details]
Patch

[Jonathan Bedard]

Might get tripped up by TCC prompts on Catalina, but I think our bots should be fine because they have password-less sudo.

[Aakash Jain]

Comment on attachment 373643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373643&action=review

> Tools/Scripts/webkitpy/test/main.py:107
>      build_version = _host.platform.build_version()

Do we need this method (_supports_building_and_running_lldb_tests) at all after this change?

Seems like it was added in https://trac.webkit.org/changeset/246662/webkit

[Jonathan Bedard]

Comment on attachment 373643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373643&action=review

>> Tools/Scripts/webkitpy/test/main.py:107
>>      build_version = _host.platform.build_version()
> 
> Do we need this method (_supports_building_and_running_lldb_tests) at all after this change?
> 
> Seems like it was added in https://trac.webkit.org/changeset/246662/webkit

I'd like to keep it until the FIX-ME is resolved.

I think there is a non-zero chance we need to do this again (because of TCC prompts), and after r247139, this is also acting as a platform check for lldb tests, since they aren't supported on Linux at the moment.

[WebKit Commit Bot]

Comment on attachment 373643 [details]
Patch

Clearing flags on attachment: 373643

Committed r247228: <https://trac.webkit.org/changeset/247228>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.