RESOLVED FIXED 199566
Register a MediaStreamTrack as media producer only if it is a capture track
https://bugs.webkit.org/show_bug.cgi?id=199566
Summary Register a MediaStreamTrack as media producer only if it is a capture track
youenn fablet
Reported 2019-07-07 19:00:48 PDT
Register a MediaStreamTrack as media producer only if it is a capture track
Attachments
Patch (2.99 KB, patch)
2019-07-07 19:14 PDT, youenn fablet
no flags
Archive of layout-test-results from ews211 for win-future (13.96 MB, application/zip)
2019-07-07 23:25 PDT, EWS Watchlist
no flags
Address post landing comments (1.47 KB, patch)
2019-07-10 09:17 PDT, youenn fablet
no flags
Address post landing comments (1.50 KB, patch)
2019-07-10 10:35 PDT, youenn fablet
no flags
youenn fablet
Comment 1 2019-07-07 19:14:18 PDT
Radar WebKit Bug Importer
Comment 2 2019-07-07 21:03:56 PDT
EWS Watchlist
Comment 3 2019-07-07 23:25:32 PDT
Comment on attachment 373613 [details] Patch Attachment 373613 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12685942 New failing tests: css3/filters/blur-various-radii.html
EWS Watchlist
Comment 4 2019-07-07 23:25:35 PDT
Created attachment 373616 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
WebKit Commit Bot
Comment 5 2019-07-08 09:26:01 PDT
Comment on attachment 373613 [details] Patch Clearing flags on attachment: 373613 Committed r247208: <https://trac.webkit.org/changeset/247208>
WebKit Commit Bot
Comment 6 2019-07-08 09:26:03 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 7 2019-07-08 19:00:36 PDT
Comment on attachment 373613 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373613&action=review > Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:74 > setMuted(document->page()->mutedState()); Change to setMuted(true)?
youenn fablet
Comment 8 2019-07-10 09:17:29 PDT
Reopening to attach new patch.
youenn fablet
Comment 9 2019-07-10 09:17:30 PDT
Created attachment 373838 [details] Address post landing comments
WebKit Commit Bot
Comment 10 2019-07-10 10:28:37 PDT
Comment on attachment 373838 [details] Address post landing comments Rejecting attachment 373838 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 373838, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/12708520
youenn fablet
Comment 11 2019-07-10 10:35:38 PDT
Created attachment 373846 [details] Address post landing comments
WebKit Commit Bot
Comment 12 2019-07-11 21:25:06 PDT
Comment on attachment 373846 [details] Address post landing comments Clearing flags on attachment: 373846 Committed r247382: <https://trac.webkit.org/changeset/247382>
WebKit Commit Bot
Comment 13 2019-07-11 21:25:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.