Bug 199566 – Register a MediaStreamTrack as media producer only if it is a capture track

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Register a MediaStreamTrack as media producer only if it is a capture track

[youenn fablet]

Created attachment 373613 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/52761361>

[EWS Watchlist]

Comment on attachment 373613 [details]
Patch

Attachment 373613 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12685942

New failing tests:
css3/filters/blur-various-radii.html

[EWS Watchlist]

Created attachment 373616 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[WebKit Commit Bot]

Comment on attachment 373613 [details]
Patch

Clearing flags on attachment: 373613

Committed r247208: <https://trac.webkit.org/changeset/247208>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 373613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373613&action=review

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:74
>              setMuted(document->page()->mutedState());

Change to setMuted(true)?

[youenn fablet]

Reopening to attach new patch.

[youenn fablet]

Created attachment 373838 [details]
Address post landing comments

[WebKit Commit Bot]

Comment on attachment 373838 [details]
Address post landing comments

Rejecting attachment 373838 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 373838, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/12708520

[youenn fablet]

Created attachment 373846 [details]
Address post landing comments

[WebKit Commit Bot]

Comment on attachment 373846 [details]
Address post landing comments

Clearing flags on attachment: 373846

Committed r247382: <https://trac.webkit.org/changeset/247382>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.