Bug 199565 - Unable to paste from Notes into Excel 365 spreadsheet
Summary: Unable to paste from Notes into Excel 365 spreadsheet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-07 17:04 PDT by Wenson Hsieh
Modified: 2019-07-08 12:00 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.11 KB, patch)
2019-07-07 17:36 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Actually add the test (10.73 KB, patch)
2019-07-07 17:50 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Fix typo in ChangeLog. (10.84 KB, patch)
2019-07-08 07:32 PDT, Wenson Hsieh
cdumez: review+
Details | Formatted Diff | Diff
Patch for landing (10.78 KB, patch)
2019-07-08 08:50 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-07-07 17:04:14 PDT
<rdar://problem/43615497>
Comment 1 Wenson Hsieh 2019-07-07 17:36:20 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2019-07-07 17:50:14 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2019-07-08 07:32:58 PDT
Created attachment 373624 [details]
Fix typo in ChangeLog.
Comment 4 Chris Dumez 2019-07-08 08:35:40 PDT
Comment on attachment 373624 [details]
Fix typo in ChangeLog.

View in context: https://bugs.webkit.org/attachment.cgi?id=373624&action=review

> Source/WebCore/page/Page.h:656
> +    void setIsForSanitizingWebContent(bool isForSanitizingWebContent) { m_isForSanitizingWebContent = isForSanitizingWebContent; }

Personally, I would omit the boolean parameter since this can never be set back to false after being set to true.
Comment 5 Wenson Hsieh 2019-07-08 08:37:13 PDT
Comment on attachment 373624 [details]
Fix typo in ChangeLog.

View in context: https://bugs.webkit.org/attachment.cgi?id=373624&action=review

Thanks for the review!

>> Source/WebCore/page/Page.h:656
>> +    void setIsForSanitizingWebContent(bool isForSanitizingWebContent) { m_isForSanitizingWebContent = isForSanitizingWebContent; }
> 
> Personally, I would omit the boolean parameter since this can never be set back to false after being set to true.

Sounds good — will remove the bool param and make this just set m_isForSanitizingWebContent to true.
Comment 6 Wenson Hsieh 2019-07-08 08:50:39 PDT
Created attachment 373628 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-07-08 11:59:55 PDT
Comment on attachment 373628 [details]
Patch for landing

Clearing flags on attachment: 373628

Committed r247222: <https://trac.webkit.org/changeset/247222>