Bug 199542 - [ContentChangeObserver] Difficult to control videos on iqiyi.com as the actions are mouse hover
Summary: [ContentChangeObserver] Difficult to control videos on iqiyi.com as the actio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-05 21:43 PDT by zalan
Modified: 2019-07-07 07:52 PDT (History)
9 users (show)

See Also:


Attachments
Patch (14.38 KB, patch)
2019-07-05 21:51 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (14.34 KB, patch)
2019-07-05 22:07 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (14.39 KB, patch)
2019-07-07 06:47 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-07-05 21:43:31 PDT
1px wide clickable element prevents us from sending the click
Comment 1 zalan 2019-07-05 21:43:45 PDT
<rdar://problem/51886813>
Comment 2 zalan 2019-07-05 21:51:19 PDT
Created attachment 373562 [details]
Patch
Comment 3 zalan 2019-07-05 22:07:32 PDT
Created attachment 373563 [details]
Patch
Comment 4 Simon Fraser (smfr) 2019-07-06 11:25:43 PDT
Comment on attachment 373563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373563&action=review

> Source/WebCore/ChangeLog:9
> +        Decouple isVisuallyHidden and isConsideredVisible.Just because an element is not visually hidden (1px wide content)

. Just

> Source/WebCore/ChangeLog:10
> +        it is not necessarily qualified to be visible in the context of hover heuristic.

Who says?
Comment 5 zalan 2019-07-06 12:22:15 PDT
(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 373563 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373563&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Decouple isVisuallyHidden and isConsideredVisible.Just because an element is not visually hidden (1px wide content)
> 
> . Just
> 
> > Source/WebCore/ChangeLog:10
> > +        it is not necessarily qualified to be visible in the context of hover heuristic.
> 
> Who says?
radars.
Comment 6 zalan 2019-07-07 06:47:05 PDT
Created attachment 373596 [details]
Patch
Comment 7 WebKit Commit Bot 2019-07-07 07:52:25 PDT
Comment on attachment 373596 [details]
Patch

Clearing flags on attachment: 373596

Committed r247200: <https://trac.webkit.org/changeset/247200>
Comment 8 WebKit Commit Bot 2019-07-07 07:52:26 PDT
All reviewed patches have been landed.  Closing bug.