RESOLVED FIXED 199542
[ContentChangeObserver] Difficult to control videos on iqiyi.com as the actions are mouse hover 
https://bugs.webkit.org/show_bug.cgi?id=199542
Summary [ContentChangeObserver] Difficult to control videos on iqiyi.com as the actio...
alan baradlay
Reported 2019-07-05 21:43:31 PDT
1px wide clickable element prevents us from sending the click
Attachments
Patch (14.38 KB, patch)
2019-07-05 21:51 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (14.34 KB, patch)
2019-07-05 22:07 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (14.39 KB, patch)
2019-07-07 06:47 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan baradlay
Comment 1 2019-07-05 21:43:45 PDT
<rdar://problem/51886813>
alan baradlay
Comment 2 2019-07-05 21:51:19 PDT
Created attachment 373562 [details] Patch
alan baradlay
Comment 3 2019-07-05 22:07:32 PDT
Created attachment 373563 [details] Patch
Simon Fraser (smfr)
Comment 4 2019-07-06 11:25:43 PDT
Comment on attachment 373563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373563&action=review > Source/WebCore/ChangeLog:9 > + Decouple isVisuallyHidden and isConsideredVisible.Just because an element is not visually hidden (1px wide content) . Just > Source/WebCore/ChangeLog:10 > + it is not necessarily qualified to be visible in the context of hover heuristic. Who says?
alan baradlay
Comment 5 2019-07-06 12:22:15 PDT
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 373563 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373563&action=review > > > Source/WebCore/ChangeLog:9 > > + Decouple isVisuallyHidden and isConsideredVisible.Just because an element is not visually hidden (1px wide content) > > . Just > > > Source/WebCore/ChangeLog:10 > > + it is not necessarily qualified to be visible in the context of hover heuristic. > > Who says? radars.
alan baradlay
Comment 6 2019-07-07 06:47:05 PDT
Created attachment 373596 [details] Patch
WebKit Commit Bot
Comment 7 2019-07-07 07:52:25 PDT
Comment on attachment 373596 [details] Patch Clearing flags on attachment: 373596 Committed r247200: <https://trac.webkit.org/changeset/247200>
WebKit Commit Bot
Comment 8 2019-07-07 07:52:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.