RESOLVED FIXED 199541
switch(String) needs to check for exceptions when resolving the string
https://bugs.webkit.org/show_bug.cgi?id=199541
Summary switch(String) needs to check for exceptions when resolving the string
Michael Saboff
Reported 2019-07-05 20:06:16 PDT
A String value for a switch statement may be an unresolved rope and could throw an exception during resolution. Switch statement processing needs to handle the exception.
Attachments
Patch (6.09 KB, patch)
2019-07-05 20:12 PDT, Michael Saboff
mark.lam: review+
Michael Saboff
Comment 1 2019-07-05 20:06:33 PDT
Michael Saboff
Comment 2 2019-07-05 20:12:17 PDT
Mark Lam
Comment 3 2019-07-05 20:58:57 PDT
Comment on attachment 373560 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373560&action=review r=me with throwScope declaration fix. > Source/JavaScriptCore/dfg/DFGOperations.cpp:2478 > nit: can you remove this empty line? > Source/JavaScriptCore/jit/JITOperations.cpp:2320 > + auto throwScope = DECLARE_THROW_SCOPE(vm); You should declare this at the top of the function at the earliest possible location. This is the recommended best practice unless there's a really good reason not to.
Michael Saboff
Comment 4 2019-07-06 06:33:40 PDT
(In reply to Mark Lam from comment #3) > Comment on attachment 373560 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373560&action=review > > r=me with throwScope declaration fix. > > > Source/JavaScriptCore/dfg/DFGOperations.cpp:2478 > > > > nit: can you remove this empty line? > > > Source/JavaScriptCore/jit/JITOperations.cpp:2320 > > + auto throwScope = DECLARE_THROW_SCOPE(vm); > > You should declare this at the top of the function at the earliest possible > location. This is the recommended best practice unless there's a really > good reason not to. I made these changes.
Michael Saboff
Comment 5 2019-07-06 06:34:53 PDT
Note You need to log in before you can comment on or make changes to this bug.