Bug 199541 – switch(String) needs to check for exceptions when resolving the string

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

A String value for a switch statement may be an unresolved rope and could throw an exception during resolution.  Switch statement processing needs to handle the exception.

[Michael Saboff]

<rdar://problem/52669115>

[Michael Saboff]

Created attachment 373560 [details]
Patch

[Mark Lam]

Comment on attachment 373560 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373560&action=review

r=me with throwScope declaration fix.

> Source/JavaScriptCore/dfg/DFGOperations.cpp:2478
>  

nit: can you remove this empty line?

> Source/JavaScriptCore/jit/JITOperations.cpp:2320
> +        auto throwScope = DECLARE_THROW_SCOPE(vm);

You should declare this at the top of the function at the earliest possible location.  This is the recommended best practice unless there's a really good reason not to.

[Michael Saboff]

(In reply to Mark Lam from comment #3)
> Comment on attachment 373560 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373560&action=review
> 
> r=me with throwScope declaration fix.
> 
> > Source/JavaScriptCore/dfg/DFGOperations.cpp:2478
> >  
> 
> nit: can you remove this empty line?
> 
> > Source/JavaScriptCore/jit/JITOperations.cpp:2320
> > +        auto throwScope = DECLARE_THROW_SCOPE(vm);
> 
> You should declare this at the top of the function at the earliest possible
> location.  This is the recommended best practice unless there's a really
> good reason not to.

I made these changes.

[Michael Saboff]

Committed r247194: <https://trac.webkit.org/changeset/247194>