Bug 199538 – MediaStreamTrackPrivate should always call readyStateChanged on the main thread

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

MediaStreamTrackPrivate should always call readyStateChanged on the main thread

[Radar WebKit Bug Importer]

<rdar://problem/52709106>

[youenn fablet]

Created attachment 373605 [details]
Patch

[EWS Watchlist]

Comment on attachment 373605 [details]
Patch

Attachment 373605 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12684467

New failing tests:
fast/block/float/float-with-anonymous-previous-sibling.html

[EWS Watchlist]

Created attachment 373608 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[youenn fablet]

Comment on attachment 373605 [details]
Patch

win bot failure is unrelated

[Eric Carlson]

Comment on attachment 373605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373605&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSource.h:71
>      , public CanMakeWeakPtr<RealtimeMediaSource>

Is this still needed? If it isn't used in any of the derived classes, the only use in this class was in scheduleDeferredTask.

[youenn fablet]

(In reply to Eric Carlson from comment #6)
> Comment on attachment 373605 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373605&action=review
> 
> > Source/WebCore/platform/mediastream/RealtimeMediaSource.h:71
> >      , public CanMakeWeakPtr<RealtimeMediaSource>
> 
> Is this still needed? If it isn't used in any of the derived classes, the
> only use in this class was in scheduleDeferredTask.

It is needed right now by ScreenDisplayCaptureSourceMac.
We might be able to change the implementation though to remove it.

[WebKit Commit Bot]

Comment on attachment 373605 [details]
Patch

Clearing flags on attachment: 373605

Committed r247211: <https://trac.webkit.org/changeset/247211>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.