Bug 199528 – Fix accidental copies in NetworkLoadChecker.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Michael Catanzaro]

Coverity noticed that we are copying a ResourceRequest and a ContentExtensionResultOrError in NetworkLoadChecker::checkRequest by mistake, when the intent was to move them as rvalue references.

[Michael Catanzaro]

Created attachment 373527 [details]
Patch

[EWS Watchlist]

Comment on attachment 373527 [details]
Patch

Attachment 373527 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12670825

New failing tests:
svg/text/textpath-reference-update.html

[EWS Watchlist]

Created attachment 373550 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Michael Catanzaro]

Ping owners.

[youenn fablet]

Comment on attachment 373527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373527&action=review

> Source/WebKit/ChangeLog:10
> +        references.

I am not sure this is actually doing redundant copies but this looks better anyway.

[Michael Catanzaro]

Comment on attachment 373527 [details]
Patch

I'm not sure if commit-queue will allow this....

[WebKit Commit Bot]

Comment on attachment 373527 [details]
Patch

Clearing flags on attachment: 373527

Committed r249806: <https://trac.webkit.org/changeset/249806>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55300242>

[Radar WebKit Bug Importer]

<rdar://problem/55300243>