Bug 199528 - Fix accidental copies in NetworkLoadChecker.cpp
Summary: Fix accidental copies in NetworkLoadChecker.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Trivial
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks: 104114
  Show dependency treegraph
 
Reported: 2019-07-05 12:58 PDT by Michael Catanzaro
Modified: 2019-09-12 06:54 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.37 KB, patch)
2019-07-05 13:00 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (14.08 MB, application/zip)
2019-07-05 15:59 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-07-05 12:58:36 PDT
Coverity noticed that we are copying a ResourceRequest and a ContentExtensionResultOrError in NetworkLoadChecker::checkRequest by mistake, when the intent was to move them as rvalue references.
Comment 1 Michael Catanzaro 2019-07-05 13:00:42 PDT
Created attachment 373527 [details]
Patch
Comment 2 EWS Watchlist 2019-07-05 15:59:35 PDT Comment hidden (spam)
Comment 3 EWS Watchlist 2019-07-05 15:59:37 PDT Comment hidden (spam)
Comment 4 Michael Catanzaro 2019-08-02 13:55:24 PDT
Ping owners.
Comment 5 youenn fablet 2019-09-12 03:15:42 PDT
Comment on attachment 373527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373527&action=review

> Source/WebKit/ChangeLog:10
> +        references.

I am not sure this is actually doing redundant copies but this looks better anyway.
Comment 6 Michael Catanzaro 2019-09-12 06:22:04 PDT
Comment on attachment 373527 [details]
Patch

I'm not sure if commit-queue will allow this....
Comment 7 WebKit Commit Bot 2019-09-12 06:53:05 PDT
Comment on attachment 373527 [details]
Patch

Clearing flags on attachment: 373527

Committed r249806: <https://trac.webkit.org/changeset/249806>
Comment 8 WebKit Commit Bot 2019-09-12 06:53:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-09-12 06:54:45 PDT
<rdar://problem/55300242>
Comment 10 Radar WebKit Bug Importer 2019-09-12 06:54:45 PDT
<rdar://problem/55300243>