Bug 199518 - Add fetch quirk for www.bnz.co.nz
Summary: Add fetch quirk for www.bnz.co.nz
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-05 09:03 PDT by youenn fablet
Modified: 2019-07-05 13:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2019-07-05 09:06 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (1.43 KB, patch)
2019-07-05 12:45 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-07-05 09:03:42 PDT 
Add fetch quirk for www.bnz.co.nz
Comment 1 youenn fablet 2019-07-05 09:05:18 PDT 
<rdar://problem/52230914>
Comment 2 youenn fablet 2019-07-05 09:06:25 PDT 
Created attachment 373499 [details]
Patch
Comment 3 Chris Dumez 2019-07-05 12:04:37 PDT 
Comment on attachment 373499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373499&action=review

> Source/WebCore/page/Quirks.cpp:97
> +    if (equalLettersIgnoringASCIICase(host, "www.thrivepatientportal.com"))

I would have written this as a single return statement with || conditions.
Comment 4 youenn fablet 2019-07-05 12:45:53 PDT 
Created attachment 373526 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-07-05 13:13:15 PDT 
Comment on attachment 373526 [details]
Patch for landing

Clearing flags on attachment: 373526

Committed r247172: <https://trac.webkit.org/changeset/247172>
Comment 6 WebKit Commit Bot 2019-07-05 13:13:16 PDT 
All reviewed patches have been landed.  Closing bug.