WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
199510
[ATK] Do not use C linkage for functions using C++ features
https://bugs.webkit.org/show_bug.cgi?id=199510
Summary
[ATK] Do not use C linkage for functions using C++ features
Adrian Perez
Reported
2019-07-05 01:58:27 PDT
Clang correctly warns about the following: In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-f34946be-9.cpp:1: In file included from ../Source/WebCore/editing/atk/FrameSelectionAtk.cpp:29: ../Source/WebCore/accessibility/atk/WebKitAccessible.h:74:31: warning: 'webkitAccessibleGetAccessibilityObject' has C-linkage specified, but returns user-defined type 'WebCore::AccessibilityObject &' which is incompatible with C [-Wreturn-type-c-linkage] WebCore::AccessibilityObject& webkitAccessibleGetAccessibilityObject(WebKitAccessible*); ^
Attachments
Patch
(2.17 KB, patch)
2019-07-05 02:05 PDT
,
Adrian Perez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2019-07-05 01:58:43 PDT
<
rdar://problem/52674702
>
Adrian Perez
Comment 2
2019-07-05 02:05:10 PDT
Created
attachment 373485
[details]
Patch
WebKit Commit Bot
Comment 3
2019-07-05 04:23:25 PDT
Comment on
attachment 373485
[details]
Patch Clearing flags on attachment: 373485 Committed
r247149
: <
https://trac.webkit.org/changeset/247149
>
WebKit Commit Bot
Comment 4
2019-07-05 04:23:27 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug