Bug 199510 - [ATK] Do not use C linkage for functions using C++ features
Summary: [ATK] Do not use C linkage for functions using C++ features
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-05 01:58 PDT by Adrian Perez
Modified: 2019-07-05 04:23 PDT (History)
12 users (show)

See Also:

Attachments
Patch (2.17 KB, patch)
2019-07-05 02:05 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2019-07-05 01:58:27 PDT 
Clang correctly warns about the following:

In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-f34946be-9.cpp:1:
In file included from ../Source/WebCore/editing/atk/FrameSelectionAtk.cpp:29:
../Source/WebCore/accessibility/atk/WebKitAccessible.h:74:31: warning: 'webkitAccessibleGetAccessibilityObject' has C-linkage specified, but returns user-defined type 'WebCore::AccessibilityObject &' which is incompatible with C [-Wreturn-type-c-linkage]
WebCore::AccessibilityObject& webkitAccessibleGetAccessibilityObject(WebKitAccessible*);
                              ^
Comment 1 Radar WebKit Bug Importer 2019-07-05 01:58:43 PDT 
<rdar://problem/52674702>
Comment 2 Adrian Perez 2019-07-05 02:05:10 PDT 
Created attachment 373485 [details]
Patch
Comment 3 WebKit Commit Bot 2019-07-05 04:23:25 PDT 
Comment on attachment 373485 [details]
Patch

Clearing flags on attachment: 373485

Committed r247149: <https://trac.webkit.org/changeset/247149>
Comment 4 WebKit Commit Bot 2019-07-05 04:23:27 PDT 
All reviewed patches have been landed.  Closing bug.