Bug 199504 - [iOS] Context Menu - Add to Reading List does nothing
Summary: [iOS] Context Menu - Add to Reading List does nothing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-04 13:50 PDT by Dean Jackson
Modified: 2019-07-05 16:42 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.66 KB, patch)
2019-07-04 13:53 PDT, Dean Jackson
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-07-04 13:50:49 PDT
[iOS] Context Menu - Add to Reading List does nothing
Comment 1 Dean Jackson 2019-07-04 13:51:23 PDT
<rdar://problem/52554137>
Comment 2 Dean Jackson 2019-07-04 13:53:26 PDT
Created attachment 373471 [details]
Patch
Comment 3 Anders Carlsson 2019-07-04 16:37:19 PDT
Comment on attachment 373471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373471&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm:290
> +        RELEASE_LOG(ContextMenu, "Executing action for type: %s", elementActionTypeToUIActionIdentifier([elementAction type]).UTF8String);

Do you really need to log here?
Comment 4 Dean Jackson 2019-07-05 16:35:05 PDT
Committed r247185: <https://trac.webkit.org/changeset/247185>
Comment 5 Dean Jackson 2019-07-05 16:42:55 PDT
Comment on attachment 373471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373471&action=review

>> Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm:290
>> +        RELEASE_LOG(ContextMenu, "Executing action for type: %s", elementActionTypeToUIActionIdentifier([elementAction type]).UTF8String);
> 
> Do you really need to log here?

No. But it seems we're more happy to release log these days.