Scribble Heap::m_worldState on destructor

[Tadeu Zagallo]

...

[Tadeu Zagallo]

Created attachment 373465 [details]
Patch

[Sam Weinig]

Comment on attachment 373465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373465&action=review

> Source/JavaScriptCore/heap/Heap.cpp:342
> +    m_worldState.store(0xbadbeef0u);

I think a comment here clarifying why this store is being made would be instructive.

[Tadeu Zagallo]

Comment on attachment 373465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373465&action=review

Thanks for the review!

>> Source/JavaScriptCore/heap/Heap.cpp:342
>> +    m_worldState.store(0xbadbeef0u);
> 
> I think a comment here clarifying why this store is being made would be instructive.

That makes sense, I'll add it.

[Tadeu Zagallo]

Created attachment 373483 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 373483 [details]
Patch for landing

Clearing flags on attachment: 373483

Committed r247160: <https://trac.webkit.org/changeset/247160>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/52690607>

[Tadeu Zagallo]

I just realized this value won't work... it will clear the conn bit. I'll land a follow-up patch to change it to 0xbadbeeff.

[Tadeu Zagallo]

Committed r247166: <https://trac.webkit.org/changeset/247166>