Bug 199490 - Touching media controls sometimes shows software keyboard
Summary: Touching media controls sometimes shows software keyboard
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
Keywords: InRadar
Depends on:
Reported: 2019-07-03 19:55 PDT by Eric Carlson
Modified: 2019-07-05 09:22 PDT (History)
6 users (show)

See Also:

Patch (1.63 KB, patch)
2019-07-03 19:59 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch (19.19 KB, patch)
2019-07-04 15:41 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-07-03 19:55:40 PDT
Touching media controls immediately after page load sometimes shows software keyboard.
Comment 1 Eric Carlson 2019-07-03 19:55:52 PDT
Comment 2 Eric Carlson 2019-07-03 19:59:49 PDT
Created attachment 373450 [details]
Comment 3 Wenson Hsieh 2019-07-04 14:12:00 PDT
Comment on attachment 373450 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=373450&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2899
> +        if (oldFocusedElement == newFocusedElement && newFocusedElement->isContentEditable())

I got a chance to debug this a bit — a few observations…

1. newFocusedElement in this case is <INPUT id='' type='text' class='active’> when tapping on the media controls.
2. It looks like this change would make the bug go away by preventing the <INPUT id='' type='text' class='active’> from being refocused. This is because the input element itself is not content editable, but rather, is a text form control (which contains an editable area).
Comment 4 Wenson Hsieh 2019-07-04 15:41:55 PDT
Created attachment 373473 [details]
Comment 5 Eric Carlson 2019-07-05 08:48:13 PDT
Thanks Wenson!
Comment 6 WebKit Commit Bot 2019-07-05 09:22:49 PDT
Comment on attachment 373473 [details]

Clearing flags on attachment: 373473

Committed r247158: <https://trac.webkit.org/changeset/247158>
Comment 7 WebKit Commit Bot 2019-07-05 09:22:50 PDT
All reviewed patches have been landed.  Closing bug.