Bug 199483 - Test freshness page should expose revision information for latest build on tooltip.
Summary: Test freshness page should expose revision information for latest build on to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dewei_zhu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-03 17:11 PDT by dewei_zhu
Modified: 2019-07-08 11:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (10.45 KB, patch)
2019-07-03 17:14 PDT, dewei_zhu 		no flags Details | Formatted Diff | Diff
Patch (10.52 KB, patch)
2019-07-03 17:27 PDT, dewei_zhu 		rniwa: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2019-07-03 17:11:57 PDT 
Test freshness page should expose revision information for latest build on tooltip.
Comment 1 dewei_zhu 2019-07-03 17:14:27 PDT 
Created attachment 373440 [details]
Patch
Comment 2 dewei_zhu 2019-07-03 17:27:47 PDT 
Created attachment 373442 [details]
Patch
Comment 3 Ryosuke Niwa 2019-07-04 01:55:16 PDT 
Comment on attachment 373442 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373442&action=review

> Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:94
> +                    let commitSet = null;

commitSetOfLastPoint?

> Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:178
> +        for (const repository of Repository.sortByNamePreferringOnesWithURL(commitSet.repositories())) {
> +            const commit = commitSet.commitForRepository(repository);
> +            tableContent.push(element('tr', [

Better written as:
tableContent.push(Repository.sortByNamePreferringOnesWithURL(commitSet.repositories()).map((repository) => {
    ~
});
Note: CommonComponentBase._addContentToElement would unwrap nested arrays.
Comment 4 dewei_zhu 2019-07-08 11:52:51 PDT 
Landed in r247168.