Bug 199468 - Clarify threading model for WebResourceLoadStatisticsStore::dumpResourceLoadStatistics()
Summary: Clarify threading model for WebResourceLoadStatisticsStore::dumpResourceLoadS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 196307
  Show dependency tree / graph
 
Reported: 2019-07-03 15:25 PDT by Chris Dumez
Modified: 2019-07-04 14:43 PDT (History)
7 users (show)

See Also:

Attachments
Patch (13.11 KB, patch)
2019-07-03 15:29 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (13.10 KB, patch)
2019-07-03 16:41 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-07-03 15:25:57 PDT 
Clarify threading model for WebResourceLoadStatisticsStore::dumpResourceLoadStatistics() after r245517.
Comment 1 Chris Dumez 2019-07-03 15:29:45 PDT 
Created attachment 373422 [details]
Patch
Comment 2 youenn fablet 2019-07-03 16:38:45 PDT 
Comment on attachment 373422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373422&action=review

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:76
> +    void dumpResourceLoadStatistics(CompletionHandler<void(const String&)>&&) override;

final

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:82
> +    void dumpResourceLoadStatistics(CompletionHandler<void(const String&)>&&) override;

final
Comment 3 Chris Dumez 2019-07-03 16:41:09 PDT 
Created attachment 373434 [details]
Patch
Comment 4 WebKit Commit Bot 2019-07-03 17:23:32 PDT 
Comment on attachment 373434 [details]
Patch

Clearing flags on attachment: 373434

Committed r247119: <https://trac.webkit.org/changeset/247119>
Comment 5 WebKit Commit Bot 2019-07-03 17:23:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-07-03 17:24:15 PDT 
<rdar://problem/52620712>