Bug 199465 - REGRESSION (r246817): fast/events/ios/key-events-comprehensive/key-events-{control, control-shift}.html are failing
Summary: REGRESSION (r246817): fast/events/ios/key-events-comprehensive/key-events-{co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar, PlatformOnly, Regression
Depends on: 199204
Blocks:
  Show dependency tree / graph
 
Reported: 2019-07-03 15:03 PDT by Daniel Bates
Modified: 2019-07-03 16:22 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2019-07-03 15:05 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-07-03 15:03:21 PDT 
Oops! In the fix for bug #199204 I was a bit too nice. It does not make sense to allow cursor key commands when there is no selection. The tests:

fast/events/ios/key-events-comprehensive/key-events-{control, control-shift}.html are failing

fail because try to perform cursor movements (like Control + A to move to the start of the line) even when there is no selection. Handled key commands don't dispatch DOM keypress events.
Comment 1 Radar WebKit Bug Importer 2019-07-03 15:03:36 PDT 
<rdar://problem/52613496>
Comment 2 Daniel Bates 2019-07-03 15:05:59 PDT 
Created attachment 373417 [details]
Patch
Comment 3 Daniel Bates 2019-07-03 16:22:49 PDT 
Comment on attachment 373417 [details]
Patch

Clearing flags on attachment: 373417

Committed r247116: <https://trac.webkit.org/changeset/247116>
Comment 4 Daniel Bates 2019-07-03 16:22:50 PDT 
All reviewed patches have been landed.  Closing bug.