Bug 199461 - Isolate CacheStorage::Engine path when hopping to a background thread
Summary: Isolate CacheStorage::Engine path when hopping to a background thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-03 13:47 PDT by youenn fablet
Modified: 2019-07-03 15:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.84 KB, patch)
2019-07-03 13:56 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-07-03 13:47:04 PDT 
Isolate CacheStorage::Engine path when hopping to a background thread
Comment 1 youenn fablet 2019-07-03 13:56:14 PDT 
Created attachment 373414 [details]
Patch
Comment 2 Chris Dumez 2019-07-03 14:02:56 PDT 
Comment on attachment 373414 [details]
Patch

is the usage on m_rootPath inside Engine::fetchEntries() correct?
Comment 3 youenn fablet 2019-07-03 14:50:22 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 373414 [details]
> Patch
> 
> is the usage on m_rootPath inside Engine::fetchEntries() correct?

Yes, it is fine.
But we should really move the code listing the files of a directory to a background thread.
Comment 4 WebKit Commit Bot 2019-07-03 15:14:10 PDT 
Comment on attachment 373414 [details]
Patch

Clearing flags on attachment: 373414

Committed r247111: <https://trac.webkit.org/changeset/247111>
Comment 5 WebKit Commit Bot 2019-07-03 15:14:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-07-03 15:15:17 PDT 
<rdar://problem/52614234>