Bug 199454 – [PlayStation] Add Buildbots for Debug/Release builds

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Don Olmstead]

Add buildbots for the PlayStation port.

[Don Olmstead]

Created attachment 373691 [details]
Patch

[Aakash Jain]

Comment on attachment 373691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373691&action=review

Schedulers seems to be missing for PlayStation builders. Without that 'buildbot checkconfig' should fail. r- due to that.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:86
> +                    { "name": "playstation-debug-build-01", "platform": "playstation" }

Nit: might be a good idea to move this section next to wincairo bots so that all the sony bots are mentioned together.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:360
> +                    },

Nit: ditto about moving above next to wincairo section.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:362
> +                      "name": "PlayStation Debug (Build)", "type": "Build", "builddir": "build",

http://docs.buildbot.net/latest/manual/configuration/builders.html?highlight=builddir says "Each builder must have a unique build directory.". same for old Buildbot (e.g.: http://docs.buildbot.net/0.8.1/Builders.html)

It seems it's better to either remove 'builddir' (to use the default) or specify a unique builddir.

> Tools/ChangeLog:10
> +        (BuildBotConfigLoader._add_dependent_modules_to_sys_modules): Deleted.

This method doesn't seems to be modified in this patch, probably a bug in prepare-ChangeLog, please delete this line.

[Stephan Szabo]

Created attachment 389196 [details]
Patch

Updated to move items, give unique builddirs, add to AnyBranch scheduler. There are no triggerables as we're not doing testing yet.

Also add playstation to some platform checks in python
- Build sometimes took longer than default time, using the same branch as win
- Build wants --[platform] like gtk, wincairo and some others
- Set builder category for platform playstation

[Aakash Jain]

Comment on attachment 389196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389196&action=review

Looks good to me. Minor comment about builder name.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:336
> +                      "name": "PlayStation Debug (Build)", "type": "Build", "builddir": "playstation-debug",

Let's avoid using spaces and brackets in builder name. That would help later-on while upgrading buildbot version, since newer buildbot versions doesn't allow spaces in builder name.

"PlayStation Debug (Build)" -> "PlayStation-Debug-Build"
"PlayStation Release (Build)" -> "PlayStation-Release-Build"

[Stephan Szabo]

Created attachment 390664 [details]
Patch

Update builder names to PlayStation-<config>-Build

[Aakash Jain]

Comment on attachment 390664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390664&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:577
> +    'PlayStation Release (Build)': ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit'],

These Unit-test also need updation.

[Stephan Szabo]

Created attachment 390667 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 390667 [details]
Patch

Clearing flags on attachment: 390667

Committed r256535: <https://trac.webkit.org/changeset/256535>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59435271>

[Aakash Jain]

> Committed r256535: <https://trac.webkit.org/changeset/256535>
Deployed on the server. Queues are now live, please connect the bots.

https://build.webkit.org/builders/PlayStation-Release-Build
https://build.webkit.org/builders/PlayStation-Debug-Build