Bug 199454 - [PlayStation] Add Buildbots for Debug/Release builds
Summary: [PlayStation] Add Buildbots for Debug/Release builds
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
Keywords: InRadar
Depends on:
Reported: 2019-07-03 10:02 PDT by Don Olmstead
Modified: 2020-02-16 05:00 PST (History)
8 users (show)

See Also:

Patch (4.34 KB, patch)
2019-07-08 19:03 PDT, Don Olmstead
aakash_jain: review-
Details | Formatted Diff | Diff
Patch (7.90 KB, patch)
2020-01-29 16:05 PST, Stephan Szabo
no flags Details | Formatted Diff | Diff
Patch (7.89 KB, patch)
2020-02-13 10:21 PST, Stephan Szabo
aakash_jain: review+
Details | Formatted Diff | Diff
Patch (7.89 KB, patch)
2020-02-13 10:32 PST, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-07-03 10:02:33 PDT
Add buildbots for the PlayStation port.
Comment 1 Don Olmstead 2019-07-08 19:03:16 PDT
Created attachment 373691 [details]
Comment 2 Aakash Jain 2019-07-09 04:12:13 PDT
Comment on attachment 373691 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=373691&action=review

Schedulers seems to be missing for PlayStation builders. Without that 'buildbot checkconfig' should fail. r- due to that.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:86
> +                    { "name": "playstation-debug-build-01", "platform": "playstation" }

Nit: might be a good idea to move this section next to wincairo bots so that all the sony bots are mentioned together.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:360
> +                    },

Nit: ditto about moving above next to wincairo section.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:362
> +                      "name": "PlayStation Debug (Build)", "type": "Build", "builddir": "build",

http://docs.buildbot.net/latest/manual/configuration/builders.html?highlight=builddir says "Each builder must have a unique build directory.". same for old Buildbot (e.g.: http://docs.buildbot.net/0.8.1/Builders.html)

It seems it's better to either remove 'builddir' (to use the default) or specify a unique builddir.

> Tools/ChangeLog:10
> +        (BuildBotConfigLoader._add_dependent_modules_to_sys_modules): Deleted.

This method doesn't seems to be modified in this patch, probably a bug in prepare-ChangeLog, please delete this line.
Comment 3 Stephan Szabo 2020-01-29 16:05:40 PST
Created attachment 389196 [details]

Updated to move items, give unique builddirs, add to AnyBranch scheduler. There are no triggerables as we're not doing testing yet.

Also add playstation to some platform checks in python
- Build sometimes took longer than default time, using the same branch as win
- Build wants --[platform] like gtk, wincairo and some others
- Set builder category for platform playstation
Comment 4 Aakash Jain 2020-02-13 10:11:05 PST
Comment on attachment 389196 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=389196&action=review

Looks good to me. Minor comment about builder name.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:336
> +                      "name": "PlayStation Debug (Build)", "type": "Build", "builddir": "playstation-debug",

Let's avoid using spaces and brackets in builder name. That would help later-on while upgrading buildbot version, since newer buildbot versions doesn't allow spaces in builder name.

"PlayStation Debug (Build)" -> "PlayStation-Debug-Build"
"PlayStation Release (Build)" -> "PlayStation-Release-Build"
Comment 5 Stephan Szabo 2020-02-13 10:21:44 PST
Created attachment 390664 [details]

Update builder names to PlayStation-<config>-Build
Comment 6 Aakash Jain 2020-02-13 10:26:20 PST
Comment on attachment 390664 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=390664&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:577
> +    'PlayStation Release (Build)': ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit'],

These Unit-test also need updation.
Comment 7 Stephan Szabo 2020-02-13 10:32:50 PST
Created attachment 390667 [details]
Comment 8 WebKit Commit Bot 2020-02-13 13:26:38 PST
Comment on attachment 390667 [details]

Clearing flags on attachment: 390667

Committed r256535: <https://trac.webkit.org/changeset/256535>
Comment 9 WebKit Commit Bot 2020-02-13 13:26:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-02-13 13:27:15 PST
Comment 11 Aakash Jain 2020-02-16 05:00:59 PST
> Committed r256535: <https://trac.webkit.org/changeset/256535>
Deployed on the server. Queues are now live, please connect the bots.