Bug 199446 – [GTK] Unreviewed test gardening

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: WebKitGTK

[Alicia Boya García]

.

[Alicia Boya García]

Created attachment 373389 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 373389 [details]
Patch for landing

Rejecting attachment 373389 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 373389, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=373389&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199446&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 373389 from bug 199446.
Fetching: https://bugs.webkit.org/attachment.cgi?id=373389
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/wpe/TestExpectations']" exit_code: 1

ERROR: LayoutTests/platform/gtk/TestExpectations:1299:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: LayoutTests/platform/gtk/TestExpectations:1299:  unexpected "["  [test/expectations] [5]
ERROR: LayoutTests/platform/gtk/TestExpectations:1301:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: LayoutTests/platform/gtk/TestExpectations:1301:  unexpected "["  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:1299:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:1299:  unexpected "["  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:1301:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:1301:  unexpected "["  [test/expectations] [5]
Total errors found: 8 in 2 files

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/wpe/TestExpectations']" exit_code: 1

ERROR: LayoutTests/platform/gtk/TestExpectations:1299:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: LayoutTests/platform/gtk/TestExpectations:1299:  unexpected "["  [test/expectations] [5]
ERROR: LayoutTests/platform/gtk/TestExpectations:1301:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: LayoutTests/platform/gtk/TestExpectations:1301:  unexpected "["  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:1299:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:1299:  unexpected "["  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:1301:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:1301:  unexpected "["  [test/expectations] [5]
Total errors found: 8 in 2 files

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/wpe/TestExpectations']" exit_code: 1
Updating OpenSource
Current branch master is up to date.
ERROR: LayoutTests/platform/gtk/TestExpectations:1299:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: LayoutTests/platform/gtk/TestExpectations:1299:  unexpected "["  [test/expectations] [5]
ERROR: LayoutTests/platform/gtk/TestExpectations:1301:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: LayoutTests/platform/gtk/TestExpectations:1301:  unexpected "["  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:1299:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:1299:  unexpected "["  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:1301:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:1301:  unexpected "["  [test/expectations] [5]
Total errors found: 8 in 2 files

Full output: https://webkit-queues.webkit.org/results/12651299

[Carlos Alberto Lopez Perez]

Comment on attachment 373389 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=373389&action=review

> LayoutTests/platform/gtk/TestExpectations:1301
> +webkit.org/b/199444 fast/events/context-activated-by-key-event.html [ Debug ] [ Crash ]
> +
> +webkit.org/b/199445 fast/forms/interactive-validation-remove-node-in-handler.html [ Debug ] [ Crash ]

This should be [ Debug Crash ]

(only a pair of brackets)

[Carlos Alberto Lopez Perez]

(In reply to Carlos Alberto Lopez Perez from comment #3)
> Comment on attachment 373389 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373389&action=review
> 
> > LayoutTests/platform/gtk/TestExpectations:1301
> > +webkit.org/b/199444 fast/events/context-activated-by-key-event.html [ Debug ] [ Crash ]
> > +
> > +webkit.org/b/199445 fast/forms/interactive-validation-remove-node-in-handler.html [ Debug ] [ Crash ]
> 
> This should be [ Debug Crash ]
> 
> (only a pair of brackets)

Sorry, wrong advice.

If you meant to write the expectation only for Debug build then it should be:

webkit.org/b/199444 [ Debug ] fast/events/context-activated-by-key-event.html [ Crash ]

[Alicia Boya García]

Outdated, closing.