Bug 199416 – [WPE][GTK] Remove flatpak sandbox

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Patrick Griffis]

[WPE][GTK] Remove flatpak sandbox

[Patrick Griffis]

Created attachment 373351 [details]
Patch

[EWS Watchlist]

Comment on attachment 373351 [details]
Patch

Attachment 373351 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12643480

New failing tests:
webgl/2.0.0/conformance/context/context-release-upon-reload.html

[EWS Watchlist]

Created attachment 373359 [details]
Archive of layout-test-results from ews116 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Michael Catanzaro]

Comment on attachment 373351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373351&action=review

> Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:130
> -    if (sandboxEnabled && isInsideFlatpak())
> -        process = flatpakSpawn(launcher.get(), m_launchOptions, argv, socketPair.client, &error.outPtr());
> -#if ENABLE(BUBBLEWRAP_SANDBOX)
> -    else if (sandboxEnabled)
> +    if (sandboxEnabled)
>          process = bubblewrapSpawn(launcher.get(), m_launchOptions, argv, &error.outPtr());
> -#endif
>      else
>  #endif

Don't we still need the isInsideFlatpak() check? Surely bubblewrap isn't going to work inside flatpak?

[Patrick Griffis]

(In reply to Michael Catanzaro from comment #4)
> Don't we still need the isInsideFlatpak() check? Surely bubblewrap isn't
> going to work inside flatpak?

ENABLE_BUBBLEWRAP_SANDBOX defaults to false when built inside Flatpak. If somebody forcefully enables it then thats on them.

[Michael Catanzaro]

(In reply to Patrick Griffis from comment #5)
> ENABLE_BUBBLEWRAP_SANDBOX defaults to false when built inside Flatpak. If
> somebody forcefully enables it then thats on them.

Well that doesn't seem like it's enough, because our flatpak runtimes are not built inside flatpak.

[Patrick Griffis]

(In reply to Michael Catanzaro from comment #6)
> (In reply to Patrick Griffis from comment #5)
> > ENABLE_BUBBLEWRAP_SANDBOX defaults to false when built inside Flatpak. If
> > somebody forcefully enables it then thats on them.
> 
> Well that doesn't seem like it's enough, because our flatpak runtimes are
> not built inside flatpak.

Alright, I'll re-add it.

[Patrick Griffis]

Created attachment 373399 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 373399 [details]
Patch

Clearing flags on attachment: 373399

Committed r247096: <https://trac.webkit.org/changeset/247096>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

o/ didn't you mention you had this working again? Looks like that never made it upstream...?

[Patrick Griffis]

(In reply to Michael Catanzaro from comment #11)
> o/ didn't you mention you had this working again? Looks like that never made
> it upstream...?

bug 204732 has a patch, will get it reviewed after a patch lands in flatpak-xdg-utils soon.