Bug 199413 - Web Inspector: Elements: DOM breakpoints context menu items inserted first when accessed via status image
Summary: Web Inspector: Elements: DOM breakpoints context menu items inserted first wh...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P3 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-02 11:32 PDT by Matt Baker
Modified: 2022-03-26 04:15 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.38 KB, patch)
2019-07-02 11:36 PDT, Matt Baker
hi: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2019-07-02 11:32:46 PDT
Summary:
DOM breakpoints context menu items inserted first when accessed via status image.

Steps to Reproduce:
1. Right-click the DOM node in the tree to show context menu
2. Add any DOM breakpoint (e.g.: Break on > Attribute Modified)
3. Right-click the DOM breakpoint indicator to show context menu

Expected:
    Add
    Edit
    Copy
    Delete
    Toggle Visibility
    -
    Forced Pseudo-Classes
    -
    Break on
    -
    Disable Breakpoint
    Delete Breakpoint
    -
    etc.

Actual:
    Break on
    -
    Disable Breakpoint
    Delete Breakpoint
    -
    Add
    Edit
    Copy
    Delete
    Toggle Visibility
    -
    Forced Pseudo-Classes
    -
    etc.
Comment 1 Matt Baker 2019-07-02 11:36:00 PDT
Created attachment 373342 [details]
Patch
Comment 2 Devin Rousso 2019-07-02 11:43:23 PDT
Comment on attachment 373342 [details]
Patch

r-, I did this intentionally.  If a user shows a context menu specifically for the breakpoint icon, it likely means that they want to do something with breakpoints, as it's pretty "small" and is way far over in the gutter area.  As such, we should put the actions for breakpoints closer to the top.
Comment 3 Matt Baker 2019-07-02 11:52:42 PDT
(In reply to Devin Rousso from comment #2)
> Comment on attachment 373342 [details]
> Patch
> 
> r-, I did this intentionally.  If a user shows a context menu specifically
> for the breakpoint icon, it likely means that they want to do something with
> breakpoints, as it's pretty "small" and is way far over in the gutter area. 
> As such, we should put the actions for breakpoints closer to the top.

I see your reasoning, however I don't think it's a good idea to render the menu for reasons like this. We show all the other menu items for the node, so it is not as if its a "DOM breakpoint only" context menu.