Bug 199394 – REGRESSION (r243240): Unable to swipe back in Safari

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

REGRESSION (r243240): Unable to swipe back in Safari

[Tim Horton]

Created attachment 373302 [details]
Patch

[Tim Horton]

<rdar://problem/51137447>

[Chris Dumez]

Comment on attachment 373302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373302&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-1900
> -    _gestureController = nullptr;

So we do not even need a call to _gestureController->disconnectFromProcess() ?

[Tim Horton]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 373302 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373302&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-1900
> > -    _gestureController = nullptr;
> 
> So we do not even need a call to _gestureController->disconnectFromProcess()
> ?

Hmm, I don't think so? The connect just bails and all is well (and they communicate by pageID so things just fall back into place. I'll check if it's safe to disconnect and if it is we'll do that just for safety/readability's sake, though.

[Tim Horton]

Created attachment 373356 [details]
Patch

[Chris Dumez]

Comment on attachment 373356 [details]
Patch

LGTM too.

[WebKit Commit Bot]

Comment on attachment 373356 [details]
Patch

Clearing flags on attachment: 373356

Committed r247073: <https://trac.webkit.org/changeset/247073>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.