Bug 199391 - [WHLSL] WHLSL::AST::Node is useless
Summary: [WHLSL] WHLSL::AST::Node is useless
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
Keywords: InRadar
Depends on:
Reported: 2019-07-01 17:28 PDT by Robin Morisset
Modified: 2019-07-03 14:21 PDT (History)
3 users (show)

See Also:

Patch (21.50 KB, patch)
2019-07-01 17:32 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff
Patch (20.11 KB, patch)
2019-07-03 13:35 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff
Patch (20.56 KB, patch)
2019-07-03 13:39 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff
Patch for landing (20.17 KB, patch)
2019-07-03 13:41 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-07-01 17:28:14 PDT
It has no member, no non-trivial method, and we never access AST node completely generically.
So WHLSL::AST::Node can be removed, as a first step towards removing the virtual table pointer from most AST nodes (and avoiding a virtual destructor call at the end of the compiler).
Comment 1 Robin Morisset 2019-07-01 17:32:33 PDT
Created attachment 373286 [details]
Comment 2 WebKit Commit Bot 2019-07-03 13:20:05 PDT
Comment on attachment 373286 [details]

Rejecting attachment 373286 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 373286, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=373286&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199391&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 373286 from bug 199391.
Fetching: https://bugs.webkit.org/attachment.cgi?id=373286
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 19 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAST.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNamedType.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNode.h
rm 'Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNode.h'
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReplaceWith.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLType.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLValue.h
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj
Hunk #1 FAILED at 857.
Hunk #3 succeeded at 13328 (offset 1 line).
Hunk #4 succeeded at 17132 (offset 2 lines).
Hunk #5 succeeded at 17173 (offset 2 lines).
1 out of 5 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12653325
Comment 3 Robin Morisset 2019-07-03 13:35:59 PDT
Created attachment 373410 [details]
Comment 4 Robin Morisset 2019-07-03 13:39:12 PDT
Created attachment 373411 [details]
Comment 5 Robin Morisset 2019-07-03 13:41:43 PDT
Created attachment 373412 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-07-03 14:20:11 PDT
Comment on attachment 373412 [details]
Patch for landing

Clearing flags on attachment: 373412

Committed r247105: <https://trac.webkit.org/changeset/247105>
Comment 7 WebKit Commit Bot 2019-07-03 14:20:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-07-03 14:21:19 PDT