Bug 199391 – [WHLSL] WHLSL::AST::Node is useless

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Robin Morisset]

It has no member, no non-trivial method, and we never access AST node completely generically.
So WHLSL::AST::Node can be removed, as a first step towards removing the virtual table pointer from most AST nodes (and avoiding a virtual destructor call at the end of the compiler).

[Robin Morisset]

Created attachment 373286 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 373286 [details]
Patch

Rejecting attachment 373286 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 373286, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=373286&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199391&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 373286 from bug 199391.
Fetching: https://bugs.webkit.org/attachment.cgi?id=373286
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 19 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAST.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNamedType.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNode.h
rm 'Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNode.h'
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReplaceWith.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLType.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLValue.h
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj
Hunk #1 FAILED at 857.
Hunk #3 succeeded at 13328 (offset 1 line).
Hunk #4 succeeded at 17132 (offset 2 lines).
Hunk #5 succeeded at 17173 (offset 2 lines).
1 out of 5 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12653325

[Robin Morisset]

Created attachment 373410 [details]
Patch

[Robin Morisset]

Created attachment 373411 [details]
Patch

[Robin Morisset]

Created attachment 373412 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 373412 [details]
Patch for landing

Clearing flags on attachment: 373412

Committed r247105: <https://trac.webkit.org/changeset/247105>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/52610670>