Bug 199381 – Pipe suport for 'cenc' init data type into CDMFairPlayStreaming

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Pipe suport for 'cenc' init data type into CDMFairPlayStreaming

[Radar WebKit Bug Importer]

<rdar://problem/52483103>

[Jer Noble]

Created attachment 373268 [details]
Patch

[EWS Watchlist]

Attachment 373268 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:111:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Comment on attachment 373268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373268&action=review

> Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:111
> +    static FourCC boxTypeName() { return "fpsdq"; }

A five character FourCC?

[Jer Noble]

(In reply to Eric Carlson from comment #4)
> Comment on attachment 373268 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373268&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:111
> > +    static FourCC boxTypeName() { return "fpsdq"; }
> 
> A five character FourCC?

Gah, I must have hit 'q' and saved it.  In good news tho:

/Volumes/Data/EWS/WebKit/Source/WebCore/platform/graphics/FourCC.h:39:9: error: static_assert failed "FourCC literals must be exactly 4 characters long"

Looks like FourCC's static checker is working great!

[Jer Noble]

Created attachment 373321 [details]
Patch for landing

[EWS Watchlist]

Attachment 373321 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:111:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

Created attachment 373324 [details]
Patch for landing

[EWS Watchlist]

Attachment 373324 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:111:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

Created attachment 373330 [details]
Patch for landing

[EWS Watchlist]

Attachment 373330 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:111:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

gtk-wk2 and wpe bots are both stuck in "unable to build without patch". Landing anyway.

[WebKit Commit Bot]

Comment on attachment 373330 [details]
Patch for landing

Clearing flags on attachment: 373330

Committed r247059: <https://trac.webkit.org/changeset/247059>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.