Bug 199381 - Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
Summary: Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-01 14:25 PDT by Jer Noble
Modified: 2019-07-02 11:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (17.94 KB, patch)
2019-07-01 14:36 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (18.08 KB, patch)
2019-07-02 07:57 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (18.08 KB, patch)
2019-07-02 08:31 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (19.39 KB, patch)
2019-07-02 09:11 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2019-07-01 14:25:33 PDT
Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
Comment 1 Radar WebKit Bug Importer 2019-07-01 14:31:43 PDT
<rdar://problem/52483103>
Comment 2 Jer Noble 2019-07-01 14:36:08 PDT
Created attachment 373268 [details]
Patch
Comment 3 EWS Watchlist 2019-07-01 14:37:54 PDT
Attachment 373268 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:111:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2019-07-01 17:42:21 PDT
Comment on attachment 373268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373268&action=review

> Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:111
> +    static FourCC boxTypeName() { return "fpsdq"; }

A five character FourCC?
Comment 5 Jer Noble 2019-07-02 07:55:36 PDT
(In reply to Eric Carlson from comment #4)
> Comment on attachment 373268 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373268&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:111
> > +    static FourCC boxTypeName() { return "fpsdq"; }
> 
> A five character FourCC?

Gah, I must have hit 'q' and saved it.  In good news tho:

/Volumes/Data/EWS/WebKit/Source/WebCore/platform/graphics/FourCC.h:39:9: error: static_assert failed "FourCC literals must be exactly 4 characters long"

Looks like FourCC's static checker is working great!
Comment 6 Jer Noble 2019-07-02 07:57:45 PDT
Created attachment 373321 [details]
Patch for landing
Comment 7 EWS Watchlist 2019-07-02 07:59:18 PDT
Attachment 373321 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:111:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Jer Noble 2019-07-02 08:31:31 PDT
Created attachment 373324 [details]
Patch for landing
Comment 9 EWS Watchlist 2019-07-02 08:33:37 PDT
Attachment 373324 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:111:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Jer Noble 2019-07-02 09:11:47 PDT
Created attachment 373330 [details]
Patch for landing
Comment 11 EWS Watchlist 2019-07-02 09:15:09 PDT
Attachment 373330 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:111:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Jer Noble 2019-07-02 10:30:21 PDT
gtk-wk2 and wpe bots are both stuck in "unable to build without patch". Landing anyway.
Comment 13 WebKit Commit Bot 2019-07-02 11:00:52 PDT
Comment on attachment 373330 [details]
Patch for landing

Clearing flags on attachment: 373330

Committed r247059: <https://trac.webkit.org/changeset/247059>
Comment 14 WebKit Commit Bot 2019-07-02 11:00:54 PDT
All reviewed patches have been landed.  Closing bug.