FetchResponse::BodyLoader should not be movable
This is currently causing a few crashes in fetch-related tests on debug bots using GCC, with "pure virtual method" error being thrown when calling FetchLoaderClient virtual methods on already-freed FetchResponse::BodyLoader objects.
Created attachment 373265 [details]
Attachment 373265 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/fetch/FetchResponse.h:37: Alphabetical sorting problem. [build/include_order] 
ERROR: Source/WebCore/ChangeLog:12: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: use-after-free [changelog/unwantedsecurityterms] 
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 373265 [details]
Classic case of moved-from undefined state bug. We still need to be careful about std::exchange/WTFMove being used correctly.
I think we should make m_bodyLoader a std::unique_ptr instead of an Optional.
Created attachment 373305 [details]
Takes the unique_ptr approach.
Comment on attachment 373305 [details]
Clearing flags on attachment: 373305
Committed r247087: <https://trac.webkit.org/changeset/247087>
All reviewed patches have been landed. Closing bug.