Bug 199358 – REGRESSION(r246963) GTK's debug build is broken

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Miguel Gomez]

The traits to use downcast are missing in AnimatedBackingStoreClient.

[Miguel Gomez]

Created attachment 373220 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 373220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373220&action=review

> Source/WebCore/ChangeLog:28
> [phone]  Miguel Gomez  <[e-mail]>
> +
> +        REGRESSION(r246963) GTK's debug build is broken
> +        https://bugs.webkit.org/show_bug.cgi?id=199358
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Add the traits to be able to downcast AnimatedBackingStoreClient.
> +
> +        * platform/graphics/nicosia/NicosiaAnimatedBackingStoreClient.h:
> +        (Nicosia::AnimatedBackingStoreClient::AnimatedBackingStoreClient):
> +        (Nicosia::AnimatedBackingStoreClient::type const):
> +        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

double changelog

> Source/WebCore/platform/graphics/nicosia/NicosiaAnimatedBackingStoreClient.h:45
> +    enum ClientType {
> +        Coordinated
> +    };

Use an enum class

> Source/WebCore/platform/graphics/nicosia/NicosiaAnimatedBackingStoreClient.h:47
> +    AnimatedBackingStoreClient(ClientType type)

explicit

[Miguel Gomez]

Created attachment 373221 [details]
Patch

[Michael Catanzaro]

Comment on attachment 373221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373221&action=review

> Source/WebCore/platform/graphics/nicosia/NicosiaAnimatedBackingStoreClient.h:47
> +    AnimatedBackingStoreClient(ClientType type)

explicit

[Miguel Gomez]

Created attachment 373222 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 373222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373222&action=review

> Source/WebCore/platform/graphics/nicosia/NicosiaAnimatedBackingStoreClient.h:43
> +    enum class ClientType {

Now that this is an emu class Client is Redundant here, use just Type

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1307
> +SPECIALIZE_TYPE_TRAITS_ANIMATEDBACKINGSTORECLIENT(WebCore::CoordinatedAnimatedBackingStoreClient, type() == Nicosia::AnimatedBackingStoreClient::ClientType::Coordinated)

Client::Client <- this is what I mean

[Miguel Gomez]

Created attachment 373227 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 373227 [details]
Patch

Clearing flags on attachment: 373227

Committed r247007: <https://trac.webkit.org/changeset/247007>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.