Bug 199358 - REGRESSION(r246963) GTK's debug build is broken
Summary: REGRESSION(r246963) GTK's debug build is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-01 05:15 PDT by Miguel Gomez
Modified: 2019-07-01 06:42 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.85 KB, patch)
2019-07-01 05:26 PDT, Miguel Gomez 		no flags Details | Formatted Diff | Diff
Patch (4.29 KB, patch)
2019-07-01 05:29 PDT, Miguel Gomez 		no flags Details | Formatted Diff | Diff
Patch (4.33 KB, patch)
2019-07-01 05:40 PDT, Miguel Gomez 		no flags Details | Formatted Diff | Diff
Patch (4.27 KB, patch)
2019-07-01 06:08 PDT, Miguel Gomez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2019-07-01 05:15:24 PDT 
The traits to use downcast are missing in AnimatedBackingStoreClient.
Comment 1 Miguel Gomez 2019-07-01 05:26:48 PDT 
Created attachment 373220 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-07-01 05:29:10 PDT 
Comment on attachment 373220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373220&action=review

> Source/WebCore/ChangeLog:28
> +2019-07-01  Miguel Gomez  <magomez@igalia.com>
> +
> +        REGRESSION(r246963) GTK's debug build is broken
> +        https://bugs.webkit.org/show_bug.cgi?id=199358
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Add the traits to be able to downcast AnimatedBackingStoreClient.
> +
> +        * platform/graphics/nicosia/NicosiaAnimatedBackingStoreClient.h:
> +        (Nicosia::AnimatedBackingStoreClient::AnimatedBackingStoreClient):
> +        (Nicosia::AnimatedBackingStoreClient::type const):
> +        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

double changelog

> Source/WebCore/platform/graphics/nicosia/NicosiaAnimatedBackingStoreClient.h:45
> +    enum ClientType {
> +        Coordinated
> +    };

Use an enum class

> Source/WebCore/platform/graphics/nicosia/NicosiaAnimatedBackingStoreClient.h:47
> +    AnimatedBackingStoreClient(ClientType type)

explicit
Comment 3 Miguel Gomez 2019-07-01 05:29:29 PDT 
Created attachment 373221 [details]
Patch
Comment 4 Michael Catanzaro 2019-07-01 05:31:27 PDT 
Comment on attachment 373221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373221&action=review

> Source/WebCore/platform/graphics/nicosia/NicosiaAnimatedBackingStoreClient.h:47
> +    AnimatedBackingStoreClient(ClientType type)

explicit
Comment 5 Miguel Gomez 2019-07-01 05:40:26 PDT 
Created attachment 373222 [details]
Patch
Comment 6 Carlos Garcia Campos 2019-07-01 05:48:26 PDT 
Comment on attachment 373222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373222&action=review

> Source/WebCore/platform/graphics/nicosia/NicosiaAnimatedBackingStoreClient.h:43
> +    enum class ClientType {

Now that this is an emu class Client is Redundant here, use just Type

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1307
> +SPECIALIZE_TYPE_TRAITS_ANIMATEDBACKINGSTORECLIENT(WebCore::CoordinatedAnimatedBackingStoreClient, type() == Nicosia::AnimatedBackingStoreClient::ClientType::Coordinated)

Client::Client <- this is what I mean
Comment 7 Miguel Gomez 2019-07-01 06:08:54 PDT 
Created attachment 373227 [details]
Patch
Comment 8 WebKit Commit Bot 2019-07-01 06:42:30 PDT 
Comment on attachment 373227 [details]
Patch

Clearing flags on attachment: 373227

Committed r247007: <https://trac.webkit.org/changeset/247007>
Comment 9 WebKit Commit Bot 2019-07-01 06:42:32 PDT 
All reviewed patches have been landed.  Closing bug.