Bug 199356 - [GStreamer] The CREATE_TRACK macro is messed up
Summary: [GStreamer] The CREATE_TRACK macro is messed up
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
Keywords: InRadar
Depends on:
Reported: 2019-07-01 04:11 PDT by Philippe Normand
Modified: 2019-07-08 03:13 PDT (History)
3 users (show)

See Also:

Patch (4.54 KB, patch)
2019-07-01 08:25 PDT, Philippe Normand
calvaris: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2019-07-01 04:11:58 PDT
The naturalSize() method was implemented in the middle ot its ifdef and the macro signature is wrong in case of VIDEO_TRACK support is disabled.
Comment 1 Philippe Normand 2019-07-01 08:25:05 PDT
Created attachment 373237 [details]
Comment 2 WebKit Commit Bot 2019-07-01 23:35:37 PDT
Comment on attachment 373237 [details]

Rejecting attachment 373237 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 373237, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/12636566
Comment 3 Philippe Normand 2019-07-08 03:08:39 PDT
Committed r247204: <https://trac.webkit.org/changeset/247204>
Comment 4 Radar WebKit Bug Importer 2019-07-08 03:13:26 PDT