WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
199356
[GStreamer] The CREATE_TRACK macro is messed up
https://bugs.webkit.org/show_bug.cgi?id=199356
Summary
[GStreamer] The CREATE_TRACK macro is messed up
Philippe Normand
Reported
2019-07-01 04:11:58 PDT
The naturalSize() method was implemented in the middle ot its ifdef and the macro signature is wrong in case of VIDEO_TRACK support is disabled.
Attachments
Patch
(4.54 KB, patch)
2019-07-01 08:25 PDT
,
Philippe Normand
calvaris
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2019-07-01 08:25:05 PDT
Created
attachment 373237
[details]
Patch
WebKit Commit Bot
Comment 2
2019-07-01 23:35:37 PDT
Comment on
attachment 373237
[details]
Patch Rejecting
attachment 373237
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 373237, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
https://webkit-queues.webkit.org/results/12636566
Philippe Normand
Comment 3
2019-07-08 03:08:39 PDT
Committed
r247204
: <
https://trac.webkit.org/changeset/247204
>
Radar WebKit Bug Importer
Comment 4
2019-07-08 03:13:26 PDT
<
rdar://problem/52770671
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug