WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
199346
Web Inspector: Remove trailing white-space
https://bugs.webkit.org/show_bug.cgi?id=199346
Summary
Web Inspector: Remove trailing white-space
Nikita Vasilyev
Reported
2019-06-29 20:36:59 PDT
I found a bunch with `[ ]+$` regexp. P.S. Can I commit changes like these without a review?
Attachments
Patch
(8.67 KB, patch)
2019-06-29 20:38 PDT
,
Nikita Vasilyev
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1
2019-06-29 20:38:41 PDT
Created
attachment 373183
[details]
Patch
Matt Baker
Comment 2
2019-06-29 21:42:07 PDT
Comment on
attachment 373183
[details]
Patch rs=me
Matt Baker
Comment 3
2019-06-29 21:45:19 PDT
(In reply to Nikita Vasilyev from
comment #0
)
> I found a bunch with `[ ]+$` regexp. > > P.S. Can I commit changes like these without a review?
Not sure, but even mechanical changes like this can benefit from a review. It can be easy to miss an unintended side effect from a seemingly straightforward bulk find/replace operation.
WebKit Commit Bot
Comment 4
2019-06-29 22:11:32 PDT
Comment on
attachment 373183
[details]
Patch Clearing flags on attachment: 373183 Committed
r246953
: <
https://trac.webkit.org/changeset/246953
>
WebKit Commit Bot
Comment 5
2019-06-29 22:11:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-06-29 22:12:19 PDT
<
rdar://problem/52404681
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug