Bug 199345 - Pass WebProcess information to platformInitializeWebProcess().
Summary: Pass WebProcess information to platformInitializeWebProcess().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-29 20:11 PDT by Basuke Suzuki
Modified: 2019-06-30 15:01 PDT (History)
7 users (show)

See Also:


Attachments
PATCH (5.19 KB, patch)
2019-06-29 20:16 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff
Try again (5.09 KB, patch)
2019-06-29 21:05 PDT, Basuke Suzuki
darin: review+
Details | Formatted Diff | Diff
PATCH (6.21 KB, patch)
2019-06-30 13:25 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2019-06-29 20:11:40 PDT
Some initialization requires web process information. Currently no information is available when platformInitializeWebProcess() is called.
Comment 1 Basuke Suzuki 2019-06-29 20:16:44 PDT
Created attachment 373182 [details]
PATCH
Comment 2 Basuke Suzuki 2019-06-29 20:21:12 PDT
On WinCairo, we will need to pass socket identifier from UIProcess to WebProcess for RemoteInspector Server.

On Windows, we need an id of destination process to copy the socket information. 

https://docs.microsoft.com/en-us/windows/desktop/api/winsock2/nf-winsock2-wsaduplicatesocketa

We figured out current WebProcessPool has WebProcess information via WebProcessProxy while initializing WebProcessCreationParameters, but that info was not passed to platformInitializeWebProcess(). We can achieve our purpose by PLATFORM patch on WebProcessPool.cpp, but having such code in platform dependent file is better.
Comment 3 Basuke Suzuki 2019-06-29 21:05:53 PDT
Created attachment 373184 [details]
Try again
Comment 4 Darin Adler 2019-06-30 12:50:18 PDT
Comment on attachment 373184 [details]
Try again

r=me
Comment 5 Basuke Suzuki 2019-06-30 13:25:45 PDT
Created attachment 373196 [details]
PATCH
Comment 6 Basuke Suzuki 2019-06-30 14:28:50 PDT
Thanks! (In reply to Darin Adler from comment #4)
> Comment on attachment 373184 [details]
> Try again
> 
> r=me

Thanks!
Comment 7 WebKit Commit Bot 2019-06-30 14:59:25 PDT
Comment on attachment 373196 [details]
PATCH

Clearing flags on attachment: 373196

Committed r246955: <https://trac.webkit.org/changeset/246955>
Comment 8 WebKit Commit Bot 2019-06-30 14:59:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-06-30 15:01:36 PDT
<rdar://problem/52428507>