Bug 199344 – RenderObject::absoluteClippedOverflowRect() should not be affected by whether composited scrolling is enabled

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Simon Fraser (smfr)]

RenderObject::absoluteClippedOverflowRect() should not be affected by whether composited scrolling is enabled

[Simon Fraser (smfr)]

Created attachment 373179 [details]
Patch, needs tests

[EWS Watchlist]

Attachment 373179 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderInline.cpp:913:  Extra space before )  [whitespace/parens] [2]
Total errors found: 1 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Created attachment 373273 [details]
Patch

[Tim Horton]

Comment on attachment 373273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373273&action=review

> LayoutTests/fast/text/mark-matches-overflow-clip-async-scrolling-expected.txt:2
> +Before scrolling: marker rects: 

Before this change, there was a rect here that was outside the bounds of the `overflow: scroll` element.

[EWS Watchlist]

Comment on attachment 373273 [details]
Patch

Attachment 373273 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12632056

New failing tests:
fast/text/mark-matches-overflow-clip-async-scrolling.html

[EWS Watchlist]

Created attachment 373276 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 373273 [details]
Patch

Attachment 373273 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12632229

New failing tests:
fast/text/mark-matches-overflow-clip-async-scrolling.html

[EWS Watchlist]

Created attachment 373277 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 373273 [details]
Patch

Attachment 373273 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12632433

New failing tests:
fast/text/mark-matches-overflow-clip-async-scrolling.html

[EWS Watchlist]

Created attachment 373282 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Tim Horton]

Created attachment 373283 [details]
Patch

[EWS Watchlist]

Comment on attachment 373283 [details]
Patch

Attachment 373283 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12633597

New failing tests:
fast/text/mark-matches-overflow-clip-async-scrolling.html

[EWS Watchlist]

Created attachment 373295 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 373283 [details]
Patch

Attachment 373283 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12633620

New failing tests:
fast/text/mark-matches-overflow-clip-async-scrolling.html

[EWS Watchlist]

Created attachment 373297 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 373283 [details]
Patch

Attachment 373283 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12633503

New failing tests:
fast/text/mark-matches-overflow-clip-async-scrolling.html

[EWS Watchlist]

Created attachment 373298 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Tim Horton]

I'm a dummy and uploaded the before result as the expected :|

[Tim Horton]

Created attachment 373299 [details]
patch

[Simon Fraser (smfr)]

Did this land?

[Tim Horton]

Don’t think so, was fighting EWS.

[Chris Lord]

absoluteClippedOverflowRect has now been replaced by absoluteClippedOverflowRectForRepaint (which is affected by composited scrolling) and absoluteClippedOverflowRectForSpatialNavigation (which isn't).