Bug 199315 – WebKit failed to build due to error LNK2019 on windows with MSVC

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[QuellaZhang]

Created attachment 373101 [details]
log_x64_build

Environment:
VS 2017 + Windows Server 2016

Issue description:
We tried to build WebKit using VS2017 on Windows Server 2016. WebKit failed to build due to error LNK2019: unresolved external symbol "public: void __cdecl JSC::JSObject::didBecomePrototype(void)" on windows with MSVC.It can be reproduced on master branch 0968ecb commit.Could you please help take a look at this? Thanks in advance!

Repro steps:
1. git clone https://github.com/WebKit/webkit d:\WebKit\src
2. open a VS 2017 x64 command prompt as admin and browse to D:\Webkit
3. extra WebKitSupportLibrary\win to D:\WebKit\src\WebKitLibraries\win
4. extra WebKitAuxiliaryLibrary\win to D:\WebKit\src\WebKitLibraries\win
5. mkdir build_x64 && pushd build_x64
6. cmake -G "Visual Studio 15 2017 Win64" -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DSHOW_BINDINGS_GENERATION_PROGRESS=1 -DDEVELOPER_MODE=ON -DENABLE_EXPERIMENTAL_FEATURES=ON -DCMAKE_SYSTEM_VERSION=10.0.17134.0 -DPORT="WinCairo" -DRUBY_LIBRARY=C:\Ruby25-x64\lib ..\src
7. msbuild /p:Configuration=Release;Platform=x64 WebKit.sln /t:Rebuild


Actual result:
WebCore.lib(UnifiedSource-4babe430-10.obj) : error LNK2019: unresolved external symbol "public: void __cdecl JSC::JSObject::didBecomePrototype(void)" (?didBecomePrototype@JSObject@JSC@@QEAAXXZ) referenced in function "public: static class JSC::Structure * __cdecl JSC::JSGlobalObject::createStructure(class JSC::VM &,class JSC::JSValue)" (?createStructure@JSGlobalObject@JSC@@SAPEAVStructure@2@AEAVVM@2@VJSValue@2@@Z) [D:\WebKit\build_x64\Source\WebKitLegacy\WebKitLegacy.vcxproj]
D:\WebKit\build_x64\bin64\WebKit.dll : fatal error LNK1120: 1 unresolved externals [D:\WebKit\build_x64\Source\WebKitLegacy\WebKitLegacy.vcxproj]
Done Building Project "D:\WebKit\build_x64\Source\WebKitLegacy\WebKitLegacy.vcxproj" (Rebuild target(s)) -- FAILED.
Done Building Project "D:\WebKit\build_x64\Source\WebKitLegacy\WebKitLegacy.vcxproj.metaproj" (Rebuild target(s)) -- FAILED.
Done Building Project "D:\WebKit\build_x64\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj.metaproj" (Rebuild target(s)) -- FAILED.
Done Building Project "D:\WebKit\build_x64\Tools\DumpRenderTree\DumpRenderTree.vcxproj.metaproj" (Rebuild target(s)) -- FAILED.

[Don Olmstead]

Does it work in VS 2019? We're planning on removing support for VS 2017 as soon as Apple updates their bots.

See https://bugs.webkit.org/show_bug.cgi?id=197288

[Fujii Hironori]

Fixed in bug 199312.

[Fujii Hironori]

*** This bug has been marked as a duplicate of bug 199312 ***