Bug 199311 - imported/blink/animations/display-inline-style-adjust.html isn't a valid ref test
Summary: imported/blink/animations/display-inline-style-adjust.html isn't a valid ref ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-27 21:30 PDT by Fujii Hironori
Modified: 2019-07-02 20:43 PDT (History)
8 users (show)

See Also:


Attachments
test case comparing "should" and "shoul<span>d</span>" (1.82 KB, patch)
2019-06-27 21:32 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
test case (1.82 KB, patch)
2019-06-28 00:34 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
test case (2.04 KB, patch)
2019-06-28 04:03 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.24 MB, application/zip)
2019-06-28 05:10 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.80 MB, application/zip)
2019-06-28 05:17 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews116 for mac-highsierra (3.04 MB, application/zip)
2019-06-28 05:51 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.69 MB, application/zip)
2019-06-28 05:59 PDT, EWS Watchlist
no flags Details
display-inline-style-adjust.html with background:white (1.27 KB, patch)
2019-07-01 02:02 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
absolute inline (756 bytes, patch)
2019-07-01 02:58 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.62 MB, application/zip)
2019-07-01 04:59 PDT, EWS Watchlist
no flags Details
A test case demonstrating position:absolute and position:static can have different dimensions (529 bytes, text/html)
2019-07-01 18:07 PDT, Fujii Hironori
no flags Details
Patch (4.55 KB, patch)
2019-07-01 18:28 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (6.77 KB, patch)
2019-07-02 18:51 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-06-27 21:30:30 PDT
imported/blink/animations/display-inline-style-adjust.html isn't a valid ref test

"should" and "shoul<span>d</span>" can end up a different result.

This test case is added in this issue.
https://bugs.chromium.org/p/chromium/issues/detail?id=389455
Comment 1 Fujii Hironori 2019-06-27 21:32:25 PDT
Created attachment 373081 [details]
test case comparing "should" and "shoul<span>d</span>"
Comment 2 Fujii Hironori 2019-06-28 00:34:52 PDT
Created attachment 373093 [details]
test case
Comment 3 Fujii Hironori 2019-06-28 04:03:10 PDT
Created attachment 373103 [details]
test case
Comment 4 EWS Watchlist 2019-06-28 05:10:40 PDT
Comment on attachment 373103 [details]
test case

Attachment 373103 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12602038

New failing tests:
imported/blink/animations/display-inline-style-adjust-2.html
Comment 5 EWS Watchlist 2019-06-28 05:10:42 PDT
Created attachment 373106 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 6 EWS Watchlist 2019-06-28 05:17:33 PDT
Comment on attachment 373103 [details]
test case

Attachment 373103 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12602049

New failing tests:
imported/blink/animations/display-inline-style-adjust-2.html
Comment 7 EWS Watchlist 2019-06-28 05:17:35 PDT
Created attachment 373107 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 8 EWS Watchlist 2019-06-28 05:51:27 PDT
Comment on attachment 373103 [details]
test case

Attachment 373103 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12602075

New failing tests:
imported/blink/animations/display-inline-style-adjust-2.html
Comment 9 EWS Watchlist 2019-06-28 05:51:29 PDT
Created attachment 373110 [details]
Archive of layout-test-results from ews116 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 10 EWS Watchlist 2019-06-28 05:59:48 PDT
Comment on attachment 373103 [details]
test case

Attachment 373103 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12602095

New failing tests:
imported/blink/animations/display-inline-style-adjust-2.html
Comment 11 EWS Watchlist 2019-06-28 05:59:50 PDT
Created attachment 373111 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5
Comment 12 Fujii Hironori 2019-07-01 02:02:17 PDT
Created attachment 373215 [details]
display-inline-style-adjust.html with background:white

legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html
is failing as one pixel image diff on GTK port.

The failing reason is the tail of "l" of default 16px font paints on the outside of bounding box.

One way to make the test pass for GTK is set background-color white to the subsequent box.
Comment 13 Fujii Hironori 2019-07-01 02:58:24 PDT
Created attachment 373218 [details]
absolute inline
Comment 14 EWS Watchlist 2019-07-01 04:59:34 PDT
Comment on attachment 373218 [details]
absolute inline

Attachment 373218 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12626217

New failing tests:
fast/inline/absolute-inline.html
Comment 15 EWS Watchlist 2019-07-01 04:59:36 PDT
Created attachment 373219 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5
Comment 16 Fujii Hironori 2019-07-01 18:07:22 PDT
Created attachment 373293 [details]
A test case demonstrating position:absolute and position:static can have different dimensions
Comment 17 Fujii Hironori 2019-07-01 18:28:34 PDT
Created attachment 373296 [details]
Patch
Comment 18 Simon Fraser (smfr) 2019-07-02 18:04:02 PDT
Comment on attachment 373296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373296&action=review

> LayoutTests/ChangeLog:10
> +        created for Blink bug, doesn't seem useful for WebKit. Just skip
> +        them for all platform.

Why not just remove them? I don't think we're bulk-importing blink tests any more.
Comment 19 Fujii Hironori 2019-07-02 18:39:02 PDT
Comment on attachment 373296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373296&action=review

>> LayoutTests/ChangeLog:10
>> +        them for all platform.
> 
> Why not just remove them? I don't think we're bulk-importing blink tests any more.

Got it. Will do so.
Comment 20 Fujii Hironori 2019-07-02 18:51:52 PDT
Created attachment 373375 [details]
Patch
Comment 21 Fujii Hironori 2019-07-02 20:42:27 PDT
Comment on attachment 373375 [details]
Patch

Clearing flags on attachment: 373375

Committed r247086: <https://trac.webkit.org/changeset/247086>
Comment 22 Fujii Hironori 2019-07-02 20:42:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 23 Radar WebKit Bug Importer 2019-07-02 20:43:24 PDT
<rdar://problem/52563701>