Bug 199305 - Web Inspector: support `console.screenshot` with subclasses of CanvasRenderingContext
Summary: Web Inspector: support `console.screenshot` with subclasses of CanvasRenderin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 199308
Blocks:
  Show dependency tree / graph
 
Reported: 2019-06-27 19:41 PDT by Devin Rousso
Modified: 2019-07-24 17:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.27 KB, patch)
2019-06-27 22:30 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (7.78 KB, patch)
2019-07-24 16:05 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (7.78 KB, patch)
2019-07-24 16:46 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-06-27 19:41:15 PDT 
.
Comment 1 Devin Rousso 2019-06-27 22:30:19 PDT 
Created attachment 373086 [details]
Patch
Comment 2 Joseph Pecoraro 2019-07-22 13:20:36 PDT 
Comment on attachment 373086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373086&action=review

r=me

> Source/WebCore/page/PageConsoleClient.cpp:327
> +    if (dataURL.isEmpty() || dataURL == "data:,") {

This seems out of place in this patch, or does this happen sometimes with empty contexts?
Comment 3 Devin Rousso 2019-07-24 16:05:42 PDT 
Created attachment 374823 [details]
Patch
Comment 4 Devin Rousso 2019-07-24 16:46:50 PDT 
Created attachment 374835 [details]
Patch
Comment 5 WebKit Commit Bot 2019-07-24 17:21:40 PDT 
Comment on attachment 374835 [details]
Patch

Clearing flags on attachment: 374835

Committed r247802: <https://trac.webkit.org/changeset/247802>
Comment 6 WebKit Commit Bot 2019-07-24 17:21:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-07-24 17:22:18 PDT 
<rdar://problem/53520667>