Bug 199304 – Web Inspector: support `console.screenshot` with ImageData and ImageBitmap

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

.

[Devin Rousso]

Created attachment 373084 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 373084 [details]
Patch

r=me

[Devin Rousso]

Created attachment 374822 [details]
Patch

[Devin Rousso]

Created attachment 374834 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374834 [details]
Patch

Rejecting attachment 374834 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 374834, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=374834&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199304&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 374834 from bug 199304.
Fetching: https://bugs.webkit.org/attachment.cgi?id=374834
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 5 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file Source/WebCore/page/PageConsoleClient.cpp
Hunk #2 FAILED at 288.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/page/PageConsoleClient.cpp.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file LayoutTests/inspector/console/console-screenshot-expected.txt
Hunk #1 FAILED at 1.
Hunk #2 succeeded at 31 with fuzz 2 (offset 7 lines).
1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/inspector/console/console-screenshot-expected.txt.rej
patching file LayoutTests/inspector/console/console-screenshot.html
Hunk #1 succeeded at 18 with fuzz 1 (offset 7 lines).
Hunk #2 succeeded at 104 with fuzz 1 (offset 19 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12805305

[Devin Rousso]

Created attachment 374846 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374846 [details]
Patch

Clearing flags on attachment: 374846

Committed r247812: <https://trac.webkit.org/changeset/247812>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53524531>