Bug 199301 - Provide overrides for UIKit's suggested actions in UIContextMenuInteraction
Summary: Provide overrides for UIKit's suggested actions in UIContextMenuInteraction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-27 17:42 PDT by Dean Jackson
Modified: 2019-06-27 18:06 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.64 KB, patch)
2019-06-27 17:47 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-06-27 17:42:03 PDT 
Provide overrides for UIKit's suggested actions in UIContextMenuInteraction
Comment 1 Radar WebKit Bug Importer 2019-06-27 17:43:42 PDT 
<rdar://problem/52297380>
Comment 2 Dean Jackson 2019-06-27 17:47:36 PDT 
Created attachment 373073 [details]
Patch
Comment 3 Tim Horton 2019-06-27 17:50:15 PDT 
Comment on attachment 373073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373073&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1191
> -@interface UIContextMenuConfiguration (NeededUntil51288435Fixed)
> +@interface UIContextMenuConfiguration (NeededUntil52295535Fixed)

oO that's quite the coincidence

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1202
> +// FIXME: I don't think this Radar is correct. 51288435 is about something else.

Seems like a silly comment :) Just fix it?
Comment 4 Dean Jackson 2019-06-27 18:05:24 PDT 
Comment on attachment 373073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373073&action=review

>> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1191
>> +@interface UIContextMenuConfiguration (NeededUntil52295535Fixed)
> 
> oO that's quite the coincidence

Haha. They fixed the original radar, which helped a bit, but not completely, so I filed a new one.

>> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1202
>> +// FIXME: I don't think this Radar is correct. 51288435 is about something else.
> 
> Seems like a silly comment :) Just fix it?

It seems like there was never a radar filed for this. I just created one.
Comment 5 Dean Jackson 2019-06-27 18:06:51 PDT 
Committed r246912: <https://trac.webkit.org/changeset/246912>